Modify updateCameraSettings command to use a toogle button instead of a formDialog.

Replace the camera icon by a video camera one.

Author: HaudinFlorence

examples/jcad.ipynb

@@ -17,8 +17,22 @@
   }
  ],
  "metadata": {
+  "kernelspec": {
+   "display_name": "Python 3 (ipykernel)",
+   "language": "python",
+   "name": "python3"
+  },
   "language_info": {
-   "name": "python"
+   "codemirror_mode": {
+    "name": "ipython",
+    "version": 3
+   },
+   "file_extension": ".py",
+   "mimetype": "text/x-python",
+   "name": "python",
+   "nbconvert_exporter": "python",
+   "pygments_lexer": "ipython3",
+   "version": "3.13.3"
   }
  },
  "nbformat": 4,

packages/base/src/commands.ts

@@ -37,7 +37,7 @@ import {
   wireframeIcon,
   transformIcon,
   pencilSolidIcon,
-  cameraSolidIcon
+  videoSolidIcon
 } from './tools';
 import keybindings from './keybindings.json';
 import { DEFAULT_MESH_COLOR } from './3dview/helpers';
@@ -1085,27 +1085,33 @@ export function addCommands(
       commands.notifyCommandChanged(CommandIDs.transform);
     }
   });
-
+  let toggled: boolean;
   commands.addCommand(CommandIDs.updateCameraSettings, {
-    label: trans.__('Camera Settings'),
+    label: trans.__('Choose between Perspective and Orthographic Projection.'),
     isEnabled: () => Boolean(tracker.currentWidget),
-    icon: cameraSolidIcon,
+    icon: videoSolidIcon,
+    isToggled: () => {
+      const current = tracker.currentWidget;
+      if (current) {
+        const content = current?.content;
+        const projection = content['Type'];
+        console.log('projection:', projection);
+        return (toggled = projection === 'Perspective');
+      } else {return false;}
+    },
     execute: async () => {
+      toggled = !toggled;
       const current = tracker.currentWidget;
-
       if (!current) {
         return;
+      } else {
+        const panel = current.content;
+        const projection = toggled
+          ? { Type: 'Perspective' }
+          : { Type: 'Orthographic' };
+        const updatePanel = CAMERA_FORM.syncData(panel);
+        updatePanel(projection);
       }
-
-      const dialog = new FormDialog({
-        model: current.model,
-        title: CAMERA_FORM.title,
-        schema: CAMERA_FORM.schema,
-        sourceData: CAMERA_FORM.default(current.content),
-        syncData: CAMERA_FORM.syncData(current.content),
-        cancelButton: true
-      });
-      await dialog.launch();
     }
   });
 

packages/base/src/tools.ts

@@ -25,7 +25,7 @@ import filletIconStr from '../style/icon/fillet.svg';
 import wireframeIconStr from '../style/icon/wireframe.svg';
 import chevronRightStr from '../style/icon/chevron-right.svg';
 import pencilSolidStr from '../style/icon/pencil-solid.svg';
-import cameraSolidStr from '../style/icon/camera-solid.svg';
+import videoSolidStr from '../style/icon/video-solid.svg';
 import terminalToolbarStr from '../style/icon/terminal-toolbar.svg';
 
 import visibilitySvg from '../style/icon/visibility.svg';
@@ -150,9 +150,9 @@ export const pencilSolidIcon = new LabIcon({
   svgstr: pencilSolidStr
 });
 
-export const cameraSolidIcon = new LabIcon({
-  name: 'jupytercad:camera-solid-icon',
-  svgstr: cameraSolidStr
+export const videoSolidIcon = new LabIcon({
+  name: 'jupytercad:video-solid-icon',
+  svgstr: videoSolidStr
 });
 
 export const terminalToolbarIcon = new LabIcon({