Suggestion split screen: Use same lighting setting#702
Merged
martinRenou merged 5 commits intojupytercad:mainfrom Apr 7, 2025
Merged
Suggestion split screen: Use same lighting setting#702martinRenou merged 5 commits intojupytercad:mainfrom
martinRenou merged 5 commits intojupytercad:mainfrom
Conversation
Contributor
|
Preview PR at appsharing.space |
Contributor
|
Integration tests report: appsharing.space |
martinRenou
force-pushed
the
split_screen_same_ambient_light
branch
from
8b01a1a to
4388d30
Compare
martinRenou
commented
Apr 7, 2025
| this._onKeyDown(e); | ||
| }); | ||
|
|
||
| // Not enabling damping since it makes the syncing between cameraL and camera trickier |
Member
Author
There was a problem hiding this comment.
I removed damping for now. We can maybe re-enable it later. The bug fix is more important IMO.
Member
Author
There was a problem hiding this comment.
We can maybe track that in an issue
trungleduc
approved these changes
Apr 7, 2025
Member
Author
|
please update snapshots |
martinRenou
force-pushed
the
split_screen_same_ambient_light
branch
from
db8b9ce to
1fa2fb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're having an issue here with the camera being shared between the two scenes. It breaks the lighting (since the main light is attached to the camera).
We'll need to use one camera per-scene and make sure the two cameras are synced. This is what this PR is doing.