refactor: remove unnecessary fields

Author: pixincreate

crates/hyperswitch_connectors/src/utils.rs

@@ -1672,13 +1672,10 @@ impl CustomerData for ConnectorCustomerData {
         self.email.clone().ok_or_else(missing_field_err("email"))
     }
     fn is_mandate_payment(&self) -> bool {
-        ((self.customer_acceptance.is_some() || self.setup_mandate_details.is_some())
-            && (self.setup_future_usage == Some(FutureUsage::OffSession)))
-            || self
-                .mandate_id
-                .as_ref()
-                .and_then(|mandate_ids| mandate_ids.mandate_reference_id.as_ref())
-                .is_some()
+        // We only need to check if the customer acceptance or setup mandate details are present and if the setup future usage is OffSession.
+        // mandate_reference_id is not needed here as we do not need to check for existing mandates.
+        (self.customer_acceptance.is_some() || self.setup_mandate_details.is_some())
+            && (self.setup_future_usage == Some(FutureUsage::OffSession))
     }
 }
 

crates/hyperswitch_domain_models/src/router_request_types.rs

@@ -182,8 +182,6 @@ pub struct ConnectorCustomerData {
     pub split_payments: Option<common_types::payments::SplitPaymentsRequest>,
     // Mandates
     pub setup_future_usage: Option<storage_enums::FutureUsage>,
-    pub mandate_id: Option<api_models::payments::MandateIds>,
-    pub off_session: Option<bool>,
     pub customer_acceptance: Option<common_payments_types::CustomerAcceptance>,
     pub setup_mandate_details: Option<mandates::MandateData>,
 }
@@ -200,8 +198,6 @@ impl TryFrom<SetupMandateRequestData> for ConnectorCustomerData {
             preprocessing_id: None,
             split_payments: None,
             setup_future_usage: data.setup_future_usage,
-            mandate_id: data.mandate_id,
-            off_session: data.off_session,
             customer_acceptance: data.customer_acceptance,
             setup_mandate_details: data.setup_mandate_details,
         })
@@ -230,8 +226,6 @@ impl
             preprocessing_id: data.preprocessing_id.clone(),
             split_payments: data.request.split_payments.clone(),
             setup_future_usage: data.request.setup_future_usage,
-            mandate_id: data.request.mandate_id.clone(),
-            off_session: data.request.off_session,
             customer_acceptance: data.request.customer_acceptance.clone(),
             setup_mandate_details: data.request.setup_mandate_details.clone(),
         })
@@ -259,8 +253,6 @@ impl TryFrom<&RouterData<flows::Session, PaymentsSessionData, response_types::Pa
             preprocessing_id: data.preprocessing_id.clone(),
             split_payments: None,
             setup_future_usage: None,
-            mandate_id: None,
-            off_session: None,
             customer_acceptance: None,
             setup_mandate_details: None,
         })

crates/router/tests/connectors/utils.rs

@@ -1109,8 +1109,6 @@ impl Default for CustomerType {
             preprocessing_id: None,
             split_payments: None,
             customer_acceptance: None,
-            mandate_id: None,
-            off_session: None,
             setup_future_usage: None,
             setup_mandate_details: None,
         };