Skip to content

Commit 6db7a63

Browse files
committed
switch from pnpm patches to juspay/xterm.js fork (upstream #5818)
Replaces the minified-mjs pnpm patches from the previous commit with a git-URL override pointing at the juspay/xterm.js fork. The fork's `fix/dispose-leaks-built` branch commits both: 1. The source-level .ts fix (upstream-ready; PR at xtermjs/xterm.js#5817, tracking issue xtermjs/xterm.js#5818). 2. Pre-built .mjs bundles so pnpm can consume the fork directly without running xterm's build toolchain at install time. Changes: - package.json: drop the two xterm patches from `patchedDependencies`; add `overrides` for `@xterm/xterm` and `@xterm/addon-webgl` pointing at `github:juspay/xterm.js#fix/dispose-leaks-built` (the addon-webgl entry uses `&path:/addons/addon-webgl` to select the monorepo subdirectory). - patches/: delete both @xterm patch files. - default.nix: bump the `fetchPnpmDeps` hash. - pnpm-lock.yaml: regenerated — pins the fork via its tarball URL + commit SHA, so the build is reproducible across machines. Verified: `nix build .#default` succeeds end-to-end; dev-server heap reproduction still shows `aliveDetached: 0, gced: 7/8` after 6 mode toggles. Previous commit (the .mjs-patch approach) is preserved in git history for record of the interim fix. Once xtermjs/xterm.js#5817 merges + an xterm release ships, this override can be dropped in favor of a plain version bump.
1 parent d804679 commit 6db7a63

5 files changed

Lines changed: 21 additions & 47 deletions

File tree

default.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ let
4646
# hash-fresh` enforces this stays in sync with pnpm-lock.yaml by forcing
4747
# fetchPnpmDeps to re-execute (--rebuild), so stale artifacts in the
4848
# binary cache can't silently satisfy a hash that no longer matches.
49-
hash = "sha256-oIcLBubUOtmUuWL3aQUcfMkv7sAAos5HhGvzB3OPYZQ=";
49+
hash = "sha256-B+bX+aTMJScRbZC55ATPAnL8tJG5QAm6fkkABpTaljY=";
5050
fetcherVersion = 3;
5151
};
5252

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717
"picomatch": "^4.0.4",
1818
"yaml": "^2.8.3",
1919
"defu": "^6.1.5",
20-
"@anthropic-ai/sdk": "^0.81.0"
20+
"@anthropic-ai/sdk": "^0.81.0",
21+
"@xterm/xterm": "github:juspay/xterm.js#fix/dispose-leaks-built",
22+
"@xterm/addon-webgl": "github:juspay/xterm.js#fix/dispose-leaks-built&path:/addons/addon-webgl"
2123
},
2224
"patchedDependencies": {
23-
"node-pty@1.1.0": "patches/node-pty@1.1.0.patch",
24-
"@xterm/xterm@6.0.0": "patches/@xterm__xterm@6.0.0.patch",
25-
"@xterm/addon-webgl@0.19.0": "patches/@xterm__addon-webgl@0.19.0.patch"
25+
"node-pty@1.1.0": "patches/node-pty@1.1.0.patch"
2626
}
2727
},
2828
"devDependencies": {

patches/@xterm__addon-webgl@0.19.0.patch

Lines changed: 0 additions & 11 deletions
This file was deleted.

patches/@xterm__xterm@6.0.0.patch

Lines changed: 0 additions & 13 deletions
This file was deleted.

pnpm-lock.yaml

Lines changed: 16 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)