Variables support in Superposition

[knutties]

We need Github like Variables support in Superposition for use in functions and webhook invocations.

[sauraww]

Database Schema For Variables

CREATE TABLE variables (
    name VARCHAR PRIMARY KEY, 
    value TEXT NOT NULL, 
    description TEXT NOT NULL, 
    change_reason TEXT NOT NULL,
    created_at TIMESTAMP WITH TIME ZONE DEFAULT NOW(),
    last_modified_at TIMESTAMP WITH TIME ZONE DEFAULT NOW(),
    created_by VARCHAR NOT NULL,
    last_modified_by VARCHAR NOT NULL
);

Column	Type	Constraints	Description
name	VARCHAR	PRIMARY KEY	Variable name
value	TEXT	NOT NULL	Variable value
description	TEXT	NOT NULL	description
change_reason	TEXT	NOT NULL	change reason
created_at	TIMESTAMP WITH TIME ZONE	DEFAULT NOW()	Creation timestamp
last_modified_at	TIMESTAMP WITH TIME ZONE	DEFAULT NOW()	Last update timestamp
created_by	VARCHAR	NOT NULL	Creator identifier
last_modified_by	VARCHAR	NOT NULL	Last modifier identifier

APIs:

GET    /admin/{org}/{workspace}/variables
POST   /admin/{org}/{workspace}/variables
PATCH    /admin/{org}/{workspace}/variables/{name}
DELETE /admin/{org}/{workspace}/variables/{name}
GET    /admin/{org}/{workspace}/variables/{variable}

[knutties]

this table is inside workspace right - so why workspace_id in the table ? Why separate id if name can do ? Can we just do it like how we have done functions already ?

[ayushjain17]

Yeah, along with the 2 points from @knutties , update api would be PATCH as per our convention and
GET /admin/{org}/{workspace}/variables/{variable}

Extra UNIQUE CONSTRAINT would also not be needed
Indexes also seem like a miss

[sauraww]

I initially considered a shared table approach for easier support of both workspace and organization variables, but realized it would compromise our workspace schema isolation. I have updated the schema to maintain that isolation.

[ayushjain17]

@sauraww
this is still missing in the list:

GET    /admin/{org}/{workspace}/variables/{variable}

also, the column should be called last_modified_at instead of updated_at