Skip to content

[custom-esbuild] Add --deploy-url to custom application builder #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chergui opened this issue Mar 26, 2024 · 4 comments · Fixed by #1732
Closed

[custom-esbuild] Add --deploy-url to custom application builder #1728

chergui opened this issue Mar 26, 2024 · 4 comments · Fixed by #1732

Comments

@chergui
Copy link

chergui commented Mar 26, 2024

Is your feature request related to a problem? Please describe.
Currently, the custom-esbuild lacks support for the deployUrl property, despite its reintroduction in the latest Angular 17.3 release.

Describe the solution you'd like
I would like to request the addition of support for the deployUrl property within the custom-esbuild. This enhancement would enable developers to specify the base URL for their applications during the build process.

Describe alternatives you've considered
One alternative solution could be for developers to manually configure the deployUrl property outside, but this approach adds complexity and reduces efficiency in the development workflow. Integrating this feature directly into the custom-esbuild would provide a more seamless experience for developers.

Additional context
Issue on Angular.

@just-jeb
Copy link
Owner

What do you get right now when you try to use it with custom-esbuild and Angular 17.3?

@chergui
Copy link
Author

chergui commented Mar 28, 2024

I have this error : "Error: Schema validation failed with the following errors: "Data path "" must NOT have additional properties(deployUrl)".

The schema file in node_modules/@angular-builders/custom-esbuild/dist/application/schema.json miss deploy url entry :

`"deployUrl": {

  "type": "string",

  "description": "Customize the base path for the URLs of resources in 'index.html' and component stylesheets. This option is only necessary for specific deployment scenarios, such as with Angular Elements or when utilizing different CDN locations."

}`

Angular 17.3.2

@angular-builders/custom-esbuild": "17.1.2-beta.1"

Thank you

@just-jeb
Copy link
Owner

just-jeb commented Apr 1, 2024

Should be solved in the latest beta version. @chergui could you validate please before I graduate?

@chergui
Copy link
Author

chergui commented Apr 1, 2024

I confirm that I no longer have the problem. THANKS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants