Skip to content

Commit cf2204f

Browse files
committed
chore: stabilize the version of ui-router in tests
- Fix tests failling with angular#1.0.8 and latest angular-ui-router (0.2.15) - Add a new test configuration with both latest version
1 parent e5bd74d commit cf2204f

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

Gruntfile.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -202,10 +202,13 @@ module.exports = function (grunt) {
202202
},
203203
shell: {
204204
testMinimal: {
205-
command: 'bower install angular#=1.0.8 angular-mocks#=1.0.8 angular-sanitize#=1.0.8 --config.directory=. --config.cwd=testDependencies'
205+
command: 'bower install angular#=1.0.8 angular-mocks#=1.0.8 angular-sanitize#=1.0.8 angular-ui-router#=0.2.0 --config.directory=. --config.cwd=testDependencies'
206206
},
207207
test1dot2: {
208-
command: 'bower install angular#=1.2.18 angular-mocks#=1.2.18 angular-sanitize#=1.2.18 --config.directory=. --config.cwd=testDependencies'
208+
command: 'bower install angular#=1.2.18 angular-mocks#=1.2.18 angular-sanitize#=1.2.18 angular-ui-router#=0.2.15 --config.directory=. --config.cwd=testDependencies'
209+
},
210+
testLatest: {
211+
command: 'bower install angular angular-mocks angular-sanitize angular-ui-router --config.directory=. --config.cwd=testDependencies'
209212
}
210213
}
211214

@@ -227,9 +230,10 @@ module.exports = function (grunt) {
227230
grunt.loadNpmTasks('grunt-shell');
228231
grunt.loadNpmTasks('grunt-text-replace');
229232

230-
grunt.registerTask('test', ['jshint', 'testMin', 'test1dot2']);
233+
grunt.registerTask('test', ['jshint', 'testMin', 'test1dot2', 'testLatest']);
231234
grunt.registerTask('testMin', ['clean:test', 'shell:testMinimal', 'karma']);
232235
grunt.registerTask('test1dot2', ['clean:test', 'shell:test1dot2', 'karma']);
236+
grunt.registerTask('testLatest', ['clean:test', 'shell:testLatest', 'karma']);
233237

234238
grunt.registerTask('default', ['test', 'concat:dev', 'uglify:dev']);
235239

karma.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ module.exports = function(config) {
1414
'testDependencies/angular/angular.js',
1515
'testDependencies/angular-mocks/angular-mocks.js',
1616
'testDependencies/angular-sanitize/angular-sanitize.js',
17-
'bower_components/angular-ui-router/release/angular-ui-router.js',
17+
'testDependencies/angular-ui-router/release/angular-ui-router.js',
1818
'bower_components/angular-ui-bootstrap-bower/ui-bootstrap-tpls.js',
1919
'bower_components/underscore/underscore.js',
2020
'src/angular-breadcrumb.js',

0 commit comments

Comments
 (0)