You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The method signatures in Redmine\Http\Response are defined with the intention that an implementing class can implement the Response interface and also the PSR-7 \Psr\Http\Message\ResponseInterface.
However the Response::getBody(): string is not compatible with ResponseInterface::getBody(): StreamInterface. So we should rename our method. Because Redmine\Http\Response was not released yet (see #357) renaming it will not be a breaking change.
I propose the signature Response::getContent(): string.
The method signatures in
Redmine\Http\Response
are defined with the intention that an implementing class can implement theResponse
interface and also the PSR-7\Psr\Http\Message\ResponseInterface
.However the
Response::getBody(): string
is not compatible withResponseInterface::getBody(): StreamInterface
. So we should rename our method. BecauseRedmine\Http\Response
was not released yet (see #357) renaming it will not be a breaking change.I propose the signature
Response::getContent(): string
.Refs #341
The text was updated successfully, but these errors were encountered: