Skip to content

Redundant request when the limit is more than the nearest multiple of hundred from the total_count #436

Closed
@akindemirci

Description

@akindemirci

In AbstractApi.php, the function retrieveData makes a redundant final request if the limit is defined over 200.

On line 357, the if statement to reset $limit to zero and end the while loop is currently like this:

$newDataSet['offset'] >= $newDataSet['total_count']

This way, the while loop continues for another request whose result will be definitely empty.

I think it should be like this:

$newDataSet['limit'] + $newDataSet['offset'] >= $newDataSet['total_count']

Thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions