Skip to content

Expose sel() #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaredpalmer opened this issue Mar 19, 2018 · 9 comments
Closed

Expose sel() #1

jaredpalmer opened this issue Mar 19, 2018 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jaredpalmer
Copy link

React Native Web's testID prop emits data-testid instead of data-test. Would be great if this could be set. Seems like you've already thought about it.

Awesome lib Kent!
@kentcdodds
Copy link
Member

Hi @jaredpalmer! Yeah, that'd be fine with me! Feel free to make a PR to allow that to be configurable 👍

@kentcdodds kentcdodds added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 19, 2018
@kentcdodds
Copy link
Member

Actually, I'm thinking of changing this to the default. Want to open a PR?

@jaredpalmer
Copy link
Author

jaredpalmer commented Mar 19, 2018 •
edited
Loading

I’m out of office right now/today. Womp womp

@kentcdodds
Copy link
Member

I'll go ahead and do it right now 👍

@kentcdodds
Copy link
Member

I'm going to go ahead and assume nobody's used the lib yet so I'll push this as a patch release :)

@kentcdodds
Copy link
Member

Published 1.0.1

I also updated my blog post about these attributes so it's consistant.

@dnlsandiego
Copy link
Contributor

How about expanding the name sel to select? Was reading through the source and found the name confusing at first glance. Only after reading your blog post did I find out what it was short for. I mean it's only going to be 3 characters more 😄.

If you agree, I'd be glad to submit a PR for it.

(Really lovin this library btw. Finally found a testing library with a philosophy I agree and am comfortable with)

@kentcdodds
Copy link
Member

That'd be fine with me 👍 It's an internal function anyway so I don't mind renaming it to be more clear. Definitely wont be a breaking change 👍

@kentcdodds
Copy link
Member

And by that I mean, yes, I'd love a PR!

julienw pushed a commit to julienw/react-testing-library that referenced this issue Dec 20, 2018
@gnapse
chore: refactor custom matchers (testing-library#1)
e6efd07 
* Remove unneeded if/else logic in custom matchers

* Use common message format for all custom matchers

* Check html element in toBeInTheDOM
@laurage laurage mentioned this issue Apr 15, 2020
Closed
lucbpz pushed a commit to lucbpz/react-testing-library that referenced this issue Jul 26, 2020
@Gpx
Merge pull request testing-library#1 from Gpx/deploy
1de4322 
feat: 🎸 implement userEvent.click
@gajagajago gajagajago mentioned this issue Oct 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kentcdodds @jaredpalmer @dnlsandiego