Skip to content

Commit 1e1613a

Browse files
LiBaokun96brauner
authored andcommitted
netfs: Delete subtree of 'fs/netfs' when netfs module exits
In netfs_init() or fscache_proc_init(), we create dentry under 'fs/netfs', but in netfs_exit(), we only delete the proc entry of 'fs/netfs' without deleting its subtree. This triggers the following WARNING: ================================================================== remove_proc_entry: removing non-empty directory 'fs/netfs', leaking at least 'requests' WARNING: CPU: 4 PID: 566 at fs/proc/generic.c:717 remove_proc_entry+0x160/0x1c0 Modules linked in: netfs(-) CPU: 4 UID: 0 PID: 566 Comm: rmmod Not tainted 6.11.0-rc3 torvalds#860 RIP: 0010:remove_proc_entry+0x160/0x1c0 Call Trace: <TASK> netfs_exit+0x12/0x620 [netfs] __do_sys_delete_module.isra.0+0x14c/0x2e0 do_syscall_64+0x4b/0x110 entry_SYSCALL_64_after_hwframe+0x76/0x7e ================================================================== Therefore use remove_proc_subtree() instead of remove_proc_entry() to fix the above problem. Fixes: 7eb5b3e ("netfs, fscache: Move /proc/fs/fscache to /proc/fs/netfs and put in a symlink") Cc: [email protected] Signed-off-by: Baokun Li <[email protected]> Link: https://lore.kernel.org/r/[email protected] Acked-by: David Howells <[email protected]> Signed-off-by: Christian Brauner <[email protected]>
1 parent c594d30 commit 1e1613a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

fs/netfs/main.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ static int __init netfs_init(void)
142142

143143
error_fscache:
144144
error_procfile:
145-
remove_proc_entry("fs/netfs", NULL);
145+
remove_proc_subtree("fs/netfs", NULL);
146146
error_proc:
147147
mempool_exit(&netfs_subrequest_pool);
148148
error_subreqpool:
@@ -159,7 +159,7 @@ fs_initcall(netfs_init);
159159
static void __exit netfs_exit(void)
160160
{
161161
fscache_exit();
162-
remove_proc_entry("fs/netfs", NULL);
162+
remove_proc_subtree("fs/netfs", NULL);
163163
mempool_exit(&netfs_subrequest_pool);
164164
kmem_cache_destroy(netfs_subrequest_slab);
165165
mempool_exit(&netfs_request_pool);

0 commit comments

Comments
 (0)