Skip to content

Commit 7b0c93b

Browse files
committed
tests(webserver): fix flaky test which could query previous tests tasks
1 parent c64f15a commit 7b0c93b

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
id: sleep-short
2+
namespace: io.kestra.tests
3+
4+
tasks:
5+
- id: sleep
6+
type: io.kestra.plugin.core.flow.Sleep
7+
duration: PT3S

webserver/src/test/java/io/kestra/webserver/controllers/api/ExecutionControllerRunnerTest.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1312,14 +1312,16 @@ void shouldPauseExecutionByIdsRunningFlows() throws TimeoutException, QueueExcep
13121312
}
13131313

13141314
@Test
1315-
@LoadFlows({"flows/valids/sleep.yml"})
1315+
@LoadFlows({"flows/valids/sleep-short.yml"})
1316+
// use a dedicated Flow to avoid clash with other tests
13161317
void shouldPauseExecutionByQueryRunningFlows() throws TimeoutException, QueueException {
1317-
Execution result1 = runnerUtils.runOneUntilRunning(null, "io.kestra.tests", "sleep");
1318-
Execution result2 = runnerUtils.runOneUntilRunning(null, "io.kestra.tests", "sleep");
1319-
Execution result3 = runnerUtils.runOneUntilRunning(null, "io.kestra.tests", "sleep");
1318+
var flowId = "sleep-short";
1319+
Execution result1 = runnerUtils.runOneUntilRunning(null, "io.kestra.tests", flowId);
1320+
Execution result2 = runnerUtils.runOneUntilRunning(null, "io.kestra.tests", flowId);
1321+
Execution result3 = runnerUtils.runOneUntilRunning(null, "io.kestra.tests", flowId);
13201322

13211323
BulkResponse response = client.toBlocking().retrieve(
1322-
HttpRequest.POST("/api/v1/executions/pause/by-query?namespace=" + result1.getNamespace(), null),
1324+
HttpRequest.POST("/api/v1/executions/pause/by-query?flowId="+flowId+"&namespace=" + result1.getNamespace(), null),
13231325
BulkResponse.class
13241326
);
13251327
assertThat(response.getCount()).isEqualTo(3);

0 commit comments

Comments
 (0)