cargo clippy --fix

Author: kivikakk

examples/iterator_replace.rs

@@ -27,7 +27,7 @@ fn main() {
     let doc = "This is my input.\n\n1. Also [my](#) input.\n2. Certainly *my* input.\n";
     let orig = "my";
     let repl = "your";
-    let html = replace_text(&doc, &orig, &repl);
+    let html = replace_text(doc, orig, repl);
 
     println!("{}", html);
 }

examples/sample.rs

@@ -38,7 +38,7 @@ fn large() {
         let doc = "This is my input.\n\n1. Also [my](#) input.\n2. Certainly *my* input.\n";
         let orig = "my";
         let repl = "your";
-        let html = replace_text(&doc, &orig, &repl);
+        let html = replace_text(doc, orig, repl);
 
         println!("{}", html);
         // Output:

examples/update-readme.rs

@@ -49,7 +49,7 @@ fn main() -> Result<(), Box<dyn Error>> {
 
                 if next_block_is_help_body {
                     next_block_is_help_body = false;
-                    assert!(ncb.info == "" && ncb.literal.starts_with(HELP_START));
+                    assert!(ncb.info.is_empty() && ncb.literal.starts_with(HELP_START));
                     let mut content = String::new();
                     let mut cmd = std::process::Command::new("cargo");
                     content.push_str(

flake.nix

@@ -121,6 +121,7 @@
             "cargo"
             "rustc"
             "rust-analyzer"
+            "clippy"
           ])
           pkgs.cargo-fuzz
           pkgs.python3

src/main.rs

@@ -369,7 +369,7 @@ fn main() -> Result<(), Box<dyn Error>> {
         formatter(root, &options, &mut bw, &plugins)?;
         bw.flush()?;
     } else if cli.inplace {
-        let output_filename = cli.files.unwrap().get(0).unwrap().clone();
+        let output_filename = cli.files.unwrap().first().unwrap().clone();
         let mut bw = BufWriter::new(fs::File::create(output_filename)?);
         formatter(root, &options, &mut bw, &plugins)?;
         bw.flush()?;

src/tests/front_matter.rs

@@ -10,7 +10,7 @@ fn round_trip_one_field() {
     let input = "---\nlayout: post\n---\nText\n";
     let root = parse_document(&arena, input, &options);
     let mut buf = Vec::new();
-    format_commonmark(&root, &options, &mut buf).unwrap();
+    format_commonmark(root, &options, &mut buf).unwrap();
     assert_eq!(&String::from_utf8(buf).unwrap(), input);
 }
 
@@ -22,7 +22,7 @@ fn round_trip_wide_delimiter() {
     let input = "\u{04fc}\nlayout: post\n\u{04fc}\nText\n";
     let root = parse_document(&arena, input, &options);
     let mut buf = Vec::new();
-    format_commonmark(&root, &options, &mut buf).unwrap();
+    format_commonmark(root, &options, &mut buf).unwrap();
     assert_eq!(&String::from_utf8(buf).unwrap(), input);
 }
 
@@ -105,9 +105,7 @@ fn trailing_space_open() {
     let root = parse_document(&arena, input, &options);
 
     let found = root
-        .descendants()
-        .filter(|n| matches!(n.data.borrow().value, NodeValue::FrontMatter(..)))
-        .next();
+        .descendants().find(|n| matches!(n.data.borrow().value, NodeValue::FrontMatter(..)));
 
     assert!(found.is_none(), "no FrontMatter expected");
 }
@@ -122,9 +120,7 @@ fn leading_space_open() {
     let root = parse_document(&arena, input, &options);
 
     let found = root
-        .descendants()
-        .filter(|n| matches!(n.data.borrow().value, NodeValue::FrontMatter(..)))
-        .next();
+        .descendants().find(|n| matches!(n.data.borrow().value, NodeValue::FrontMatter(..)));
 
     assert!(found.is_none(), "no FrontMatter expected");
 }
@@ -139,9 +135,7 @@ fn leading_space_close() {
     let root = parse_document(&arena, input, &options);
 
     let found = root
-        .descendants()
-        .filter(|n| matches!(n.data.borrow().value, NodeValue::FrontMatter(..)))
-        .next();
+        .descendants().find(|n| matches!(n.data.borrow().value, NodeValue::FrontMatter(..)));
 
     assert!(found.is_none(), "no FrontMatter expected");
 }
@@ -156,9 +150,7 @@ fn trailing_space_close() {
     let root = parse_document(&arena, input, &options);
 
     let found = root
-        .descendants()
-        .filter(|n| matches!(n.data.borrow().value, NodeValue::FrontMatter(..)))
-        .next();
+        .descendants().find(|n| matches!(n.data.borrow().value, NodeValue::FrontMatter(..)));
 
     assert!(found.is_none(), "no FrontMatter expected");
 }
@@ -173,9 +165,7 @@ fn second_line() {
     let root = parse_document(&arena, input, &options);
 
     let found = root
-        .descendants()
-        .filter(|n| matches!(n.data.borrow().value, NodeValue::FrontMatter(..)))
-        .next();
+        .descendants().find(|n| matches!(n.data.borrow().value, NodeValue::FrontMatter(..)));
 
     assert!(found.is_none(), "no FrontMatter expected");
 }
@@ -190,9 +180,7 @@ fn fm_only_with_trailing_newline() {
     let root = parse_document(&arena, input, &options);
 
     let found = root
-        .descendants()
-        .filter(|n| matches!(n.data.borrow().value, NodeValue::FrontMatter(..)))
-        .next();
+        .descendants().find(|n| matches!(n.data.borrow().value, NodeValue::FrontMatter(..)));
 
     assert!(found.is_some(), "front matter expected");
 }
@@ -207,9 +195,7 @@ fn fm_only_without_trailing_newline() {
     let root = parse_document(&arena, input, &options);
 
     let found = root
-        .descendants()
-        .filter(|n| matches!(n.data.borrow().value, NodeValue::FrontMatter(..)))
-        .next();
+        .descendants().find(|n| matches!(n.data.borrow().value, NodeValue::FrontMatter(..)));
 
     assert!(found.is_some(), "front matter expected");
 }