fix(heex): self closing tag on same line #702
Merged
+39
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrocp
commented
Nov 25, 2025
| use crate::arena_tree; | ||
| #[cfg(feature = "phoenix_heex")] | ||
| pub use crate::parser::phoenix_heex::NodeHeexBlock; | ||
| pub use crate::parser::phoenix_heex::{HeexNode, NodeHeexBlock}; |
Contributor
Author
There was a problem hiding this comment.
I had to export HeexNode to use on my NIF (to have Elixir/Rust integration)
Owner
|
Nice! And yes, I will tag you if something comes up and I can't work out it :) MDEx would be most affected and I wouldn't wanna break it by accident! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kivikakk here's a fix for a bug I found running the example in leandrocp/mdex#274
Idk when the next version is coming out but I'll test more edge cases soon, either way please always feel free to tag me on any issue/PR related to Phoenix HEEx.