Skip to content

Conversation

@Mrmaxmeier
Copy link
Contributor

Hi,

I noticed that comrak's fuzzing targets are somewhat outdated and fail to build. The fixes to the harnesses are quite small (df59cf3) but I've also included some cleanup commits and two new harnesses.

While experimenting with fuzzers I ran into the following bug: I've included it as a #[should_panic] test since I'm not sure what the intended behaviour is. 🙃

[test]
// FIXME
#[should_panic = "assertion failed: (sp.end.column - sp.start.column + 1 == x) || rem == 0"]
fn relaxed_autolink_email_in_footnote() {
    assert_ast_match!(
        [
            extension.autolink,
            extension.footnotes,
            parse.relaxed_autolinks
        ],
        "[^[email protected]\nA]:\n",
        (document (1:1-1:1234) [
            // TODO: what should this be parsed as?
        ]),
    );
}

Let me know if I should drop any of the commits -- clippy's suggestions seem reasonable though I can understand if somebody doesn't like them.

@kivikakk
Copy link
Owner

Hi there! Thank you for this! It's true that I mostly just test on the all_options fuzzer these days; I'm very happy to have these all back in order.

I've looked through the clippy cleanups and I'm happy to accept them all. IIRC in the past there were some suggestions I used to leave un-applied because the changes weren't compatible with our MSRV, but I can build and test everything in this branch successfully on 1.65 so LGTM :)

I'll think on the FIXME you've added and figure out what could reasonably be intended! @digitalmoksha might also have an opinion as the author of relaxed_autolinks.

Thanks again, this is a lovely PR 💜

@kivikakk kivikakk merged commit 36b06b8 into kivikakk:main Sep 13, 2025
22 checks passed
@Mrmaxmeier Mrmaxmeier deleted the fuzzer-cleanup branch September 13, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants