Add support for inline footnotes #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This is amazing — thank you so much! I'll do my usual thing and run fuzzers against it for a few hours before merging. |
Owner
|
Fuzzing terminated; the minimised case can be reproduced with this: printf '^[\t\r]' | cargo run -- -e footnotes -e inline-footnotesFuzzing can be run with |
Contributor
Author
|
Thanks for the details @kivikakk! I've pushed a fix for handling whitespace-only footnote, and have run fuzzer for some time - nothing popped up. Please let me know if there are any other issues! |
Owner
|
Thank you so much for your contribution! ❤️ |
Owner
|
This is part of Comrak 0.44.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation supports footnotes with reference in the text and definition in separate paragraph. This PR adds support inline footnote syntax, supported in Obsidian and Pandoc.