Skip to content

Conversation

@Kuuuube
Copy link
Contributor

@Kuuuube Kuuuube commented Oct 24, 2025

Fixes #647

Unsure if this needs cleanup. Tried to follow the existing codebase and style as closely as possible.

Also noticed that the project was failing to build (before I made any changes) without a cargo update. I didn't push the cargo lock changes but I can if you'd like.

Not using "Discord" in the docs since I noticed #421 did not mention Discord by name anywhere. Unsure if this is an intentional choice and there's some reason for omitting it or not.

@kivikakk
Copy link
Owner

Heya, thank you so much for this! This is a really nice clean change.

Also noticed that the project was failing to build (before I made any changes) without a cargo update. I didn't push the cargo lock changes but I can if you'd like.

Give deets! Both current main (e00c9e8) and this PR build OK without changes for me on dev and in CI, but there might be a compiler version-specific issue (like a dependency relaxing its MSRV in a newer version), which would be nice to address.

Not using "Discord" in the docs since I noticed #421 did not mention Discord by name anywhere. Unsure if this is an intentional choice and there's some reason for omitting it or not.

I personally don't have anything in particular for or against mentioning it, but I can definitely see logic in not making a point of claiming alignment with any particular corporate-owned brand or implementation.

@kivikakk kivikakk merged commit 7e4303b into kivikakk:main Oct 24, 2025
22 of 23 checks passed
@kivikakk
Copy link
Owner

Looks great, thank you! Running the fuzzer as usual but the changes look very unlikely to hide anything. This should go out in the next Comrak release. :)

@Kuuuube
Copy link
Contributor Author

Kuuuube commented Oct 24, 2025

Thank you for the quick review and merge!

Give deets!

onig_sys blowing up cc for me. Running Arch linux and cc (GCC) 15.2.1 20250813. cargo update bumps onig_sys from 69.8.1 to 69.9.1 which seems to work fine.

@kivikakk
Copy link
Owner

Thanks for the contribution! :)

onig_sys blowing up cc for me. Running Arch linux and cc (GCC) 15.2.1 20250813. cargo update bumps onig_sys from 69.8.1 to 69.9.1 which seems to work fine.

Ahhh, got it. I was tracking this in trishume/syntect#578 / #568 and forgot to actually bump our Syntect pin. Doing that brings up the onig_sys dep. Will fix shortly; thanks for the extra information!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for discord style subtext

2 participants