Update onig_sys dependency; bump MSRV to 1.70. #649
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onig_sys69.8.1.onig_sys, but with Syntect support it's pulled in.onig_sys69.9.1sets an MSRV of 1.70.I'm happy to bump our MSRV to 1.70 to mitigate this unfortunate and kind of tangled issue. I note Debian stable (trixie) bundles 1.85, which seems to me to be a pretty good sign we're being pretty conservative.
Note that Syntect 5.3.0, which is the first version of Syntect to force
onig_sys^69.9.1(via itsonig^6.5.1requirement), does not build on 1.70:Unfortunate, but not a blocker, as earlier versions work fine (and work fine with the newer
onig_sys).Fixes #568. See also #648 (comment).