fix: Incorrect sourcepos for children of multiline block quote
#653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kivikakk
force-pushed
the
sourcepos-multiline-blockquote-with-blocks
branch
from
5f8e83e to
820f4e8
Compare
Owner
|
Thanks! This is a really nice fallback; we could possibly opt to rely on it more in some places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
sourceof children of multiline block quotes.I added a method which walks the subtree of the container and updates nodes with zero end columns by adopting the end position from their deepest-last descendant or falling back to their start position. This ensures more accurate source position tracking in the AST.
Fixes #567