fix: Incorrect sourcepos for lists and its children
#666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kivikakk
approved these changes
Oct 29, 2025
Owner
kivikakk
left a comment
kivikakk
left a comment
There was a problem hiding this comment.
Incredible — all known sourcepos issues fixed?!
Comment on lines
+614
to
+615
| let children: Vec<_> = container.children().collect(); | ||
| for ch in children { |
Owner
There was a problem hiding this comment.
If I'm not mistaken, we don't need this change any more.
Contributor
Author
Owner
|
What amazing contributions you've made this last week! Thank you again! |
Contributor
Author
|
@kivikakk Yep, all known sourcepos issues fixed! If there are any new ones discovered, I am happy to fix them :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect
sourceposfor lists, items and taskitems.Fixes #541 (all other incorrect
sourceposvalues were fixed by previous PRs) 🚀