Add Visibility for support donation

Author: BPerlakiH

.github/workflows/cd.yml

@@ -61,7 +61,9 @@ jobs:
     # https://developer.apple.com/help/account/reference/supported-capabilities-macos
     - name: Remove In App Purchase capability for macOS FTP (Developer ID signing)
       if: matrix.platform == 'macOS' && matrix.destination == 'ftp'
-      run: sed -i '' '/in-app-payments/d' project.yml
+      run: |
+        sed -i '' '/in-app-payments/d' project.yml
+        plutil -insert HIDE_DONATION -bool true Support/Info.plist
 
     - name: Set VERSION from code
       shell: python

App/App_macOS.swift

@@ -196,7 +196,7 @@ struct RootView: View {
             }
             .frame(minWidth: 160)
             .safeAreaInset(edge: .bottom) {
-                if Payment.paymentButtonType() != nil && Brand.supportDonationVisible {
+                if Payment.paymentButtonType() != nil && Brand.hideDonation != true {
                     SupportKiwixButton {
                         openWindow(id: "donation")
                     }

Model/Brand.swift

@@ -54,7 +54,7 @@ enum Brand {
     // currently only used by Kiwix brand
     // if this is missing from project.yml we fall back to true
     // and hide the support for donation (for macOS FTP)
-    static let supportDonationVisible: Bool = Config.value(for: .supportDonationVisible) ?? false
+    static let hideDonation: Bool = Config.value(for: .hideDonation) ?? false
 
     static var defaultExternalLinkPolicy: ExternalLinkLoadingPolicy {
         guard let policyString: String = Config.value(for: .externalLinkDefaultPolicy),
@@ -85,7 +85,7 @@ enum Config: String {
     case showSearchSnippetInSettings = "SETTINGS_SHOW_SEARCH_SNIPPET"
     case aboutText = "CUSTOM_ABOUT_TEXT"
     case aboutWebsite = "CUSTOM_ABOUT_WEBSITE"
-    case supportDonationVisible = "SUPPORT_DONATION_VISIBLE"
+    case hideDonation = "HIDE_DONATION"
 
     static func value<T>(for key: Config) -> T? where T: LosslessStringConvertible {
         guard let object = Bundle.main.object(forInfoDictionaryKey: key.rawValue) else {

project.yml

@@ -106,7 +106,6 @@ targets:
         INFOPLIST_KEY_CFBundleDisplayName: Kiwix
         INFOPLIST_FILE: Support/Info.plist
         INFOPLIST_KEY_UILaunchStoryboardName: SplashScreenKiwix.storyboard
-        SUPPORT_DONATION_VISIBLE: true # this line is removed for macOS FTP, where the donation pop up is hidden (not supported)
     sources:
       - path: Support
         excludes: