test: change incorrect parameter

Author: kjdev

tests/compress_args.phpt

@@ -0,0 +1,60 @@
+--TEST--
+brotli_compress() functionality with arguments
+--FILE--
+<?php
+include(dirname(__FILE__) . '/data.inc');
+
+function test($data, $quality = 0, $mode = 0) {
+    echo "quality={$quality}, mode={$mode}\n";
+
+    $compressed = brotli_compress($data, $quality, $mode);
+    if ($compressed === false) {
+        echo "ERROR\n";
+        return;
+    }
+
+    if ($data === brotli_uncompress($compressed)) {
+        echo "OK\n";
+    } else {
+        echo "Error: brotli_compress\n";
+    }
+}
+
+foreach ([0, 9, 11, 20, -1] as $quality) {
+    test($data, $quality, BROTLI_GENERIC);
+}
+foreach ([0, 1, 2, 3, -1] as $mode) {
+    test($data, BROTLI_COMPRESS_LEVEL_DEFAULT, $mode);
+}
+?>
+===DONE===
+--EXPECTF--
+quality=0, mode=0
+OK
+quality=9, mode=0
+OK
+quality=11, mode=0
+OK
+quality=20, mode=0
+
+Warning: brotli_compress(): failed to compression quality (20): must be within 0..11 in %s on line %d
+ERROR
+quality=-1, mode=0
+
+Warning: brotli_compress(): failed to compression quality (-1): must be within 0..11 in %s on line %d
+ERROR
+quality=11, mode=0
+OK
+quality=11, mode=1
+OK
+quality=11, mode=2
+OK
+quality=11, mode=3
+
+Warning: brotli_compress(): failed to compression mode (3): must be BROTLI_GENERIC(0)|BROTLI_TEXT(1)|BROTLI_FONT(2) in %s on line %d
+ERROR
+quality=11, mode=-1
+
+Warning: brotli_compress(): failed to compression mode (-1): must be BROTLI_GENERIC(0)|BROTLI_TEXT(1)|BROTLI_FONT(2) in %s on line %d
+ERROR
+===DONE===

tests/incremental_compress_add_args.phpt

@@ -6,22 +6,31 @@ if (!extension_loaded('brotli')) die('skip need ext/brotli');
 ?>
 --FILE--
 <?php
-function test($quality = 0, $mode = 0) {
+function test($quality = 0, $mode = 0, $types = []) {
   echo "quality={$quality}, mode={$mode}\n";
 
-  $modeTypes = [
+  $modeTypes = array_merge([
     'BROTLI_PROCESS' => BROTLI_PROCESS,
     'BROTLI_FLUSH' => BROTLI_FLUSH,
-  ];
+  ], $types);
 
   foreach ($modeTypes as $modeTypeKey => $modeType) {
 
     $uncompressed = $compressed = '';
 
     $resource = brotli_compress_init($quality, $mode);
+    if ($resource === false) {
+      echo "ERROR\n";
+      return;
+    }
     foreach (range('a', 'z') as $c) {
       $uncompressed .= $c;
-      $compressed .= brotli_compress_add($resource, $c, $modeType);
+      $result = brotli_compress_add($resource, $c, $modeType);
+      if ($result === false) {
+        echo "ERROR: brotli_compress_add | {$modeTypeKey}\n";
+        return;
+      }
+      $compressed .= $result;
     }
     $compressed .= brotli_compress_add($resource, '', BROTLI_FINISH);
 
@@ -39,6 +48,7 @@ foreach ([0, 9, 11, 20, -1] as $quality) {
 foreach ([0, 1, 2, 3, -1] as $mode) {
   test(0, $mode);
 }
+test(0, 0, ['INCORRECT' => -1]);
 ?>
 ===DONE===
 --EXPECTF--
@@ -53,18 +63,12 @@ OK
 OK
 quality=20, mode=0
 
-Warning: brotli_compress_init(): brotli: compression level (20) must be within 0..11 in %s on line %d
-OK
-
-Warning: brotli_compress_init(): brotli: compression level (20) must be within 0..11 in %s on line %d
-OK
+Warning: brotli_compress_init(): failed to compression quality (20): must be within 0..11 in %s on line %d
+ERROR
 quality=-1, mode=0
 
-Warning: brotli_compress_init(): brotli: compression level (-1) must be within 0..11 in %s on line %d
-OK
-
-Warning: brotli_compress_init(): brotli: compression level (-1) must be within 0..11 in %s on line %d
-OK
+Warning: brotli_compress_init(): failed to compression quality (-1): must be within 0..11 in %s on line %d
+ERROR
 quality=0, mode=0
 OK
 OK
@@ -76,16 +80,16 @@ OK
 OK
 quality=0, mode=3
 
-Warning: brotli_compress_init(): brotli: compression mode (3) must be 0, 1, 2 in %s on line %d
-OK
-
-Warning: brotli_compress_init(): brotli: compression mode (3) must be 0, 1, 2 in %s on line %d
-OK
+Warning: brotli_compress_init(): failed to compression mode (3): must be BROTLI_GENERIC(0)|BROTLI_TEXT(1)|BROTLI_FONT(2) in %s on line %d
+ERROR
 quality=0, mode=-1
 
-Warning: brotli_compress_init(): brotli: compression mode (-1) must be 0, 1, 2 in %s on line %d
+Warning: brotli_compress_init(): failed to compression mode (-1): must be BROTLI_GENERIC(0)|BROTLI_TEXT(1)|BROTLI_FONT(2) in %s on line %d
+ERROR
+quality=0, mode=0
 OK
-
-Warning: brotli_compress_init(): brotli: compression mode (-1) must be 0, 1, 2 in %s on line %d
 OK
+
+Warning: brotli_compress_add(): failed to compression mode (-1): must be BROTLI_PROCESS(0)|BROTLI_FLUSH(1)|BROTLI_FINISH(2) in %s on line %d
+ERROR: brotli_compress_add | INCORRECT
 ===DONE===