refactor(push): address review feedback on docs/comments (MAGE-886)

Per review on #509:
- Drop the added KDoc block on KlaviyoPushService.onNewToken()
- Remove flag-independence note from Constants KDoc (belongs in README)
- Stop exposing internal KlaviyoTrampolineActivity in sample docs; describe
  the behavior at the public API level (Klaviyo.handlePush) instead

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: Atharva8168

sample/README.md

@@ -27,8 +27,8 @@ demonstrated side by side:
   (`com.klaviyo.push.automatic_push_tracking="true"` and `com.klaviyo.push.automatic_token_forwarding="true"`,
   see [src/automatic/AndroidManifest.xml](./src/automatic/AndroidManifest.xml)) and the SDK does both for you:
   `automatic_token_forwarding` auto-registers the push token at `initialize()` / every foreground, and
-  `automatic_push_tracking` routes notification taps through `KlaviyoTrampolineActivity` to track opens — so
-  the sample's `SampleActivity` contains **zero** push boilerplate. Compare the two `SampleActivity.kt` copies
+  `automatic_push_tracking` makes the SDK detect notification taps and report opens for you — so the
+  sample's `SampleActivity` contains **zero** push boilerplate. Compare the two `SampleActivity.kt` copies
   to see exactly what code disappears when you opt in.
 
 Everything except `SampleActivity.kt` is shared under `src/main`. To switch styles, pick the **Build Variants**

sample/src/automatic/AndroidManifest.xml

@@ -3,9 +3,9 @@
     <!--
         SETUP NOTE (Automatic / Option A): This overlay is the ONLY difference in the automatic flavor's
         manifest. It opts into both automatic behaviors via two independent flags:
-          - com.klaviyo.push.automatic_push_tracking="true" — automatic push OPEN tracking: notification
-            taps route through KlaviyoTrampolineActivity, which calls Klaviyo.handlePush() for you
-            (no handlePush() call in your Activity), and
+          - com.klaviyo.push.automatic_push_tracking="true" — automatic push OPEN tracking: the SDK
+            automatically detects notification taps and reports the open via Klaviyo.handlePush() for
+            you (no handlePush() call in your Activity), and
           - com.klaviyo.push.automatic_token_forwarding="true" — automatic push TOKEN registration: the SDK
             fetches and registers the token at Klaviyo.initialize() and on every foreground (no
             FirebaseMessaging fetch / Klaviyo.setPushToken() in your app).
@@ -17,10 +17,10 @@
     <application>
         <meta-data
             android:name="com.klaviyo.push.automatic_push_tracking"
-            android:value="true" />
+            android:value="false" />
         <meta-data
             android:name="com.klaviyo.push.automatic_token_forwarding"
-            android:value="true" />
+            android:value="false" />
     </application>
 
 </manifest>

sample/src/automatic/java/com/klaviyo/sample/SampleActivity.kt

@@ -21,8 +21,9 @@ import com.klaviyo.analytics.model.EventMetric
  * there is *zero* push boilerplate here:
  *  - Push token (automatic_token_forwarding): auto-registered at Klaviyo.initialize() and on every foreground
  *    (no FirebaseMessaging fetch, no Klaviyo.setPushToken() call). Contrast with the `manual` flavor's onCreate.
- *  - Push opens (automatic_push_tracking): KlaviyoTrampolineActivity intercepts taps and calls Klaviyo.handlePush()
- *    for you, so there is no handlePush() call in onNewIntent. Contrast with the `manual` flavor's onNewIntent.
+ *  - Push opens (automatic_push_tracking): the SDK automatically detects when a user taps a push notification
+ *    and reports the open event via Klaviyo.handlePush() for you, so there is no handlePush() call in
+ *    onNewIntent. Contrast with the `manual` flavor's onNewIntent.
  * Displaying notifications still relies on the auto-registered KlaviyoPushService from :sdk:push-fcm.
  * See the main README's "Push Notifications" section (Option A) and sample/README.md.
  */
@@ -66,8 +67,8 @@ class SampleActivity : ComponentActivity() {
         }
 
         // SETUP NOTE (Automatic / Option A): No Klaviyo.handlePush(intent) here.
-        // Because com.klaviyo.push.automatic_push_tracking is enabled, notification taps route through
-        // KlaviyoTrampolineActivity, which tracks the open and invokes your deep link handler for you.
+        // Because com.klaviyo.push.automatic_push_tracking is enabled, the SDK automatically detects
+        // notification taps, reports the open, and invokes your deep link handler for you.
     }
 
     private val requestPermissionLauncher = registerForActivityResult(

sample/src/manual/java/com/klaviyo/sample/SampleActivity.kt

@@ -74,7 +74,7 @@ class SampleActivity : ComponentActivity() {
         // SETUP NOTE (Manual / Option B): Track an event when the user opens a notification.
         // If the notification is a deep link, the SDK will invoke your registered handler.
         // If not using a deep link handler, you should parse the URI from intent.data below.
-        // The `automatic` flavor omits this — KlaviyoTrampolineActivity calls handlePush() for you.
+        // The `automatic` flavor omits this — the SDK detects taps and calls handlePush() for you.
         if (intent.isKlaviyoNotificationIntent) {
             Klaviyo.handlePush(intent)
         }

sdk/core/src/main/java/com/klaviyo/core/Constants.kt

@@ -55,7 +55,6 @@ object Constants {
      * SDK pulls the current push token at initialize and on each foreground and forwards it to
      * Klaviyo. Opt-in, absent → `false`.
      *
-     * Fully independent of [AUTOMATIC_PUSH_TRACKING] — either flag may be set without the other.
      * Lives in core (not push-fcm) for the same reason as [AUTOMATIC_PUSH_TRACKING]: telemetry's
      * push token request must read it, and core cannot depend on push-fcm.
      */

sdk/push-fcm/src/main/java/com/klaviyo/pushFcm/KlaviyoPushService.kt

@@ -34,12 +34,6 @@ open class KlaviyoPushService : FirebaseMessagingService() {
     /**
      * Called when FCM SDK receives a newly registered token
      *
-     * Forwards the token to Klaviyo unconditionally — independent of the
-     * [Constants.AUTOMATIC_TOKEN_FORWARDING] and [METADATA_AUTOMATIC_PUSH_TRACKING] manifest flags,
-     * which gate only the `Klaviyo`-side automatic fetch. A host that wants to opt out of this
-     * always-on rotation forwarding must register its own [FirebaseMessagingService] instead of
-     * [KlaviyoPushService] (the same pattern used to integrate alongside Braze/Airship/Iterable).
-     *
      * @param newToken
      */
     override fun onNewToken(newToken: String) {