refactor(kleros-sdk): implement-rabbit-ai-feedback

Author: tractorss

kleros-sdk/src/requests/fetchDisputeDetails.ts

@@ -11,7 +11,7 @@ type DisputeDetailsQueryResponse = {
   };
 };
 
-const fetchDisputeDetails = (endpoint: string, id: number) => {
+const fetchDisputeDetails = async (endpoint: string, id: number) => {
   const query = `
     query DisputeDetails {
     dispute(id: ${id}) {
@@ -26,14 +26,9 @@ const fetchDisputeDetails = (endpoint: string, id: number) => {
 `;
 
   try {
-    return request<DisputeDetailsQueryResponse>(endpoint, query)
-      .then((res) => res)
-      .catch((err) => {
-        throw new Error(`Error querying Dispute Details , endpoint : ${endpoint}, message : ${err?.message}`);
-      });
+    return await request<DisputeDetailsQueryResponse>(endpoint, query);
   } catch (error: any) {
-    console.log(`Query Error : ${error?.message}`);
-    return undefined;
+    throw new Error(`Error querying Dispute Details , endpoint : ${endpoint}, message : ${error?.message}`);
   }
 };
 

kleros-sdk/src/requests/fetchDisputeTemplateFromId.ts

@@ -7,7 +7,7 @@ type DisputeTemplateQueryResponse = {
   };
 };
 
-const fetchDisputeTemplateFromId = (endpoint: string, id: number) => {
+const fetchDisputeTemplateFromId = async (endpoint: string, id: number) => {
   const query = `
     query DisputeTemplate {
         disputeTemplate(id: ${id}) {
@@ -18,14 +18,9 @@ const fetchDisputeTemplateFromId = (endpoint: string, id: number) => {
 `;
 
   try {
-    return request<DisputeTemplateQueryResponse>(endpoint, query)
-      .then((res) => res)
-      .catch((err) => {
-        throw new Error(`Error querying Dispute Template Registry , endpoint : ${endpoint}, message : ${err?.message}`);
-      });
+    return await request<DisputeTemplateQueryResponse>(endpoint, query);
   } catch (error: any) {
-    console.log(`Query Error : ${error?.message}`);
-    return undefined;
+    throw new Error(`Error querying Dispute Template Registry , endpoint : ${endpoint}, message : ${error?.message}`);
   }
 };
 

kleros-sdk/src/utils/getDispute.ts

@@ -23,11 +23,15 @@ export const getDispute = async (disputeParameters: GetDisputeParameters): Promi
 
   const disputeDetails = await fetchDisputeDetails(coreSubgraph, disputeId);
 
-  if (!disputeDetails?.dispute) return;
+  if (!disputeDetails?.dispute) {
+    throw new Error(`Dispute details not found for disputeId: ${disputeId}`);
+  }
 
   const template = await fetchDisputeTemplateFromId(dtrSubgraph, disputeDetails.dispute.templateId);
 
-  if (!template) return;
+  if (!template) {
+    throw new Error(`Template not found for template ID: ${disputeDetails.dispute.templateId}`);
+  }
 
   const { templateData, templateDataMappings } = template.disputeTemplate;
 
@@ -38,7 +42,14 @@ export const getDispute = async (disputeParameters: GetDisputeParameters): Promi
     ...options?.additionalContext,
   };
 
-  const data = templateDataMappings ? await executeActions(JSON.parse(templateDataMappings), initialContext) : {};
+  let data = {};
+  if (templateDataMappings) {
+    try {
+      data = await executeActions(JSON.parse(templateDataMappings), initialContext);
+    } catch (err: any) {
+      throw new Error(err);
+    }
+  }
 
   const populatedTemplate = populateTemplate(templateData, data);