Skip to content

Commit dc2a42f

Browse files
committed
add Symfony 6.x support
1 parent 76b1eb1 commit dc2a42f

File tree

6 files changed

+25
-17
lines changed

6 files changed

+25
-17
lines changed

.github/workflows/CI.yml

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,25 +38,33 @@ jobs:
3838
max-parallel: 4
3939
matrix:
4040
php-version:
41-
- '8.1' # Latest supported
41+
- '8.2' # Latest supported
42+
- '8.1'
4243
- '8.0' # First php 8 version
4344
- '7.4' # Latest php 7 version
4445
- '7.3' # Lowest supported
4546
symfony-version:
4647
- '4.4' # Lowest LTS
4748
- '5.4' # Latest LTS
49+
- '6.0' # Latest LTS
4850
exclude:
4951
# Run all symfony version only on Lowest and Latest php versions, run it only one time for others
5052
- php-version: '8.0'
5153
symfony-version: '4.4'
5254
- php-version: '7.4'
5355
symfony-version: '5.4'
56+
- php-version: '7.3'
57+
symfony-version: '6.0'
58+
- php-version: '7.4'
59+
symfony-version: '6.0'
60+
- php-version: '8.0'
61+
symfony-version: '6.0'
5462
steps:
5563
- name: Check out code
5664
uses: actions/checkout@v2
5765

5866
- name: Enable coverage
59-
if: ${{ matrix.php-version == '8.1' }}
67+
if: ${{ matrix.php-version == '8.2' }}
6068
run: |
6169
echo "COVERAGE_OUTPUT_STYLE=clover" >> $GITHUB_ENV
6270
echo "COVERAGE_TYPE=xdebug" >> $GITHUB_ENV
@@ -135,10 +143,10 @@ jobs:
135143
steps:
136144
- uses: actions/checkout@v2
137145

138-
- name: Setup PHP 8.1
146+
- name: Setup PHP 8.2
139147
uses: shivammathur/setup-php@v2
140148
with:
141-
php-version: 8.1 # Latest supported
149+
php-version: 8.2 # Latest supported
142150
tools: composer
143151
coverage: none
144152
env:
@@ -203,13 +211,13 @@ jobs:
203211
# - next Symfony minor version to manage with latest supported php version
204212
matrix:
205213
php-version:
206-
- '8.2' # Current php dev version
214+
- '8.3' # Current php dev version
207215
symfony-version:
208216
- '4.4' # Lowest LTS
209217
- '5.4' # Latest LTS
210218
include:
211219
- symfony-version: '6.0' # Next symfony minor version to manage with latest supported PHP version
212-
php-version: '8.1'
220+
php-version: '8.2'
213221

214222
steps:
215223
- name: Check out code

CHANGELOG-3.1.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
* ✔️ Symfony 5.4
2424

25-
* 🧪 Set Symfony 6.0 for nightly
25+
* ✔️ Symfony 6.0
2626

2727
### Chore
2828

composer.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@
3232
"require": {
3333
"php": "^7.3 || ^8.0",
3434
"psr/container": "^1.0",
35-
"symfony/config": "^4.4 || ^5.4",
36-
"symfony/dependency-injection": "^4.4 || ^5.4",
35+
"symfony/config": "^4.4 || ^5.4 || ^6.0",
36+
"symfony/dependency-injection": "^4.4 || ^5.4 || ^6.0",
3737
"symfony/event-dispatcher": "^4.4 || ^5.4",
38-
"symfony/event-dispatcher-contracts": "^1.0 || ^2.0",
39-
"symfony/http-foundation": "^4.4 || ^5.4",
40-
"symfony/http-kernel": "^4.4 || ^5.4",
38+
"symfony/event-dispatcher-contracts": "^1.0 || ^2.0 || ^3.0",
39+
"symfony/http-foundation": "^4.4 || ^5.4 || ^6.0",
40+
"symfony/http-kernel": "^4.4 || ^5.4 || ^6.0",
4141
"yoanm/jsonrpc-server-sdk": "^3.0"
4242
},
4343
"require-dev": {
@@ -46,8 +46,8 @@
4646
"phpunit/phpunit": "^8.0 || ^9.0",
4747
"matthiasnoback/symfony-dependency-injection-test": "^3.0 || ^4.0",
4848
"matthiasnoback/symfony-config-test": "^3.0 || ^4.0",
49-
"symfony/framework-bundle": "^4.4 || ^5.4",
50-
"symfony/routing": "^4.4 || ^5.4",
49+
"symfony/framework-bundle": "^4.4 || ^5.4 || ^6.0",
50+
"symfony/routing": "^4.4 || ^5.4 || ^6.0",
5151
"yoanm/php-unit-extended": "~1.0",
5252
"phpspec/prophecy-phpunit": "^2.0",
5353
"dvdoug/behat-code-coverage": "^5.0"

src/DependencyInjection/JsonRpcHttpServerExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ private function checkMethodAwareServiceIdList(
217217

218218
if (null !== $class && !$class->implementsInterface(JsonRpcMethodAwareInterface::class)) {
219219
throw new LogicException(sprintf(
220-
'Service "%s" is taggued as JSON-RPC method aware but does not implement %s',
220+
'Service "%s" is tagged as JSON-RPC method aware but does not implement %s',
221221
$serviceId,
222222
JsonRpcMethodAwareInterface::class
223223
));

tests/Common/DependencyInjection/AbstractTestClass.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ protected function addJsonRpcMethodTag(Definition $definition, $methodName)
8484
protected function createJsonRpcMethodDefinition($class = ConcreteJsonRpcMethod::class)
8585
{
8686
return (new Definition($class))
87-
->setPrivate(false);
87+
->setPublic(true);
8888
}
8989

9090
protected function mockResolver()

tests/Functional/DependencyInjection/JsonRpcHttpServerExtensionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ public function testShouldThowAnExceptionIfMethodAwareServiceDoesNotImplementRig
178178

179179
$this->expectException(LogicException::class);
180180
$this->expectExceptionMessage(sprintf(
181-
'Service "%s" is taggued as JSON-RPC method aware but does not implement %s',
181+
'Service "%s" is tagged as JSON-RPC method aware but does not implement %s',
182182
$methodAwareServiceServiceId,
183183
JsonRpcMethodAwareInterface::class
184184
));

0 commit comments

Comments
 (0)