Skip to content

Spotless is not verified on PRs #3349

@Cali0707

Description

@Cali0707

Describe the bug
It seems like the code is not being verified to match the formatting provided by Spotless on PRs, as subsequent PRs are reformatting the code when ./hack/update-codegen.sh is run.

Expected behavior
If code is not formatted properly, some CI job fails and indicates that the code should be formatted.

To Reproduce
Create a PR with Java code and don't run the Spotless format command.

Knative release version

Additional context
Add any other context about the problem here such as proposed priority

Metadata

Metadata

Assignees

Labels

good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.triage/acceptedIssues which should be fixed (post-triage)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions