GraphicsResourceStrategy.Dispose() (#2334)

nkast · web-flow · commit 2cc80ce8d366 · 2025-05-13T18:30:21.000+03:00
similar to #1559 prevents InvalidOperationException when setting WeakReference.Target to null and the target is allready sceduled for collection. fixes the issue with GUM editor vchelaru/Gum#749
diff --git a/src/Xna.Framework.Graphics/Graphics/GraphicsResourceStrategy.cs b/src/Xna.Framework.Graphics/Graphics/GraphicsResourceStrategy.cs
@@ -34,7 +34,11 @@ public GraphicsDevice GraphicsDevice
         GraphicsResource IGraphicsResourceStrategy.GraphicsResource
         {
             get { return _graphicsResourceRef.Target as GraphicsResource;}
-            set { _graphicsResourceRef.Target = value; }
+            set 
+            {
+                if (_graphicsResourceRef.Target != null || value != null)
+                    _graphicsResourceRef.Target = value;
+            }
         }
 
         internal GraphicsResourceStrategy()

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,11 @@ public GraphicsDevice GraphicsDevice`
`34`	`34`	`GraphicsResource IGraphicsResourceStrategy.GraphicsResource`
`35`	`35`	`{`
`36`	`36`	`get { return _graphicsResourceRef.Target as GraphicsResource;}`
`37`		`- set { _graphicsResourceRef.Target = value; }`
	`37`	`+ set`
	`38`	`+ {`
	`39`	`+ if (_graphicsResourceRef.Target != null \|\| value != null)`
	`40`	`+ _graphicsResourceRef.Target = value;`
	`41`	`+ }`
`38`	`42`	`}`
`39`	`43`
`40`	`44`	`internal GraphicsResourceStrategy()`