-
Notifications
You must be signed in to change notification settings - Fork 132
auth_type hard coded in ssh2 module #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Have you measured a noticable effect? When I run |
Basically we are using some devices (Huawei) which are drastically long to send the public key so each re-connection/disconnection (before my last pull request) would lead in 10s before getting the actual prompt after password authentication. On the other hand, when using Exscript in a multiprocessing environment for up to 7000 hosts, I think that this 0.15s matters. I will create a patch and send a pull request if someone from the project agree with this. |
The use case makes sense to me... though I assume you mean that auth_method should be configurable, not auth_types. (auth_types is just a map.) |
exscript/Exscript/protocols/ssh2.py
Line 273 in cc0b63b
The supported auth_type are hardcoded in the ssh2 module. I propose to have the possibility to set the auth_type inside the SSH2 constructor which will override the hardcoded one.
The use case is to speed up authentication phase when we know which authentication type to use (most of the time password authentication), so that we don't spend extra time testing interactive, auth_agent, auto_key.
The text was updated successfully, but these errors were encountered: