When setting name attribute in old IE, make sure special characters are handled appropriately.

Author: mbest

spec/defaultBindings/attrBehaviors.js

@@ -50,6 +50,14 @@ describe('Binding: Attr', function() {
             expect(testNode.childNodes[0].outerHTML).toNotMatch('name="?([^">]+)');
         }
         expect(testNode.childNodes[0].getAttribute("name")).toEqual("");
+
+        // Check that special characters are handled appropriately
+        myValue("<A name with special &'\" chars>");
+        expect(testNode.childNodes[0].name).toEqual("<A name with special &'\" chars>");
+        if (testNode.childNodes[0].outerHTML) { // Old Firefox doesn't support outerHTML
+            expect(testNode.childNodes[0].outerHTML).toMatch('name="?<A name with special &amp;\'&quot; chars>"?');
+        }
+        expect(testNode.childNodes[0].getAttribute("name")).toEqual("<A name with special &'\" chars>");
     });
 
     it('Should respond to changes in an observable value', function() {

src/utils.js

@@ -482,7 +482,8 @@ ko.utils = (function () {
             // - http://www.matts411.com/post/setting_the_name_attribute_in_ie_dom/
             if (ieVersion <= 7) {
                 try {
-                    element.mergeAttributes(document.createElement("<input name='" + element.name + "'/>"), false);
+                    var escapedName = element.name.replace(/[&<>'"]/g, function(r){ return "&#" + r.charCodeAt(0) + ";"; });
+                    element.mergeAttributes(document.createElement("<input name='" + escapedName + "'/>"), false);
                 }
                 catch(e) {} // For IE9 with doc mode "IE9 Standards" and browser mode "IE9 Compatibility View"
             }