Skip to content

Commit 36b7a7c

Browse files
MarcoFalkeknst
authored andcommitted
Merge bitcoin-core/gui#154: qt: Support macOS Dark mode
dc4551c remove incompatibility release note for darkmode on macos (Sylvain Goumy) 303cfc6 allow darkmode on macos build (Sylvain Goumy) 78f75a2 Allow icon colorization on mac os to better support dark mode (Uplab) Pull request description: Allow icons to be colorized on macOS to support native Dark mode color scheme. Rendering on macOS Big Sur before PR: ![macos-darkmode-before-pr](https://user-images.githubusercontent.com/5577626/102502739-43f3af80-407f-11eb-9263-5bbc27b371c2.png) Rendering on macOS Big Sur after PR: ![macos-darkmode-after-pr](https://user-images.githubusercontent.com/5577626/102502678-350cfd00-407f-11eb-8b98-e271f2688c36.png) Light mode stay visually unchanged. <del>Note, that this currently only affect the build from source, as the macos dmg includes an attributes to force light color scheme on macos windows (see bitcoin#14593). </del> <del>But once all glitches are fixed, we will be able to remove this temporary fix. </del> Edit: this PR is know including the removal of `NSRequiresAquaSystemAppearance` on Info.plist file so that the color fix is apply to every build. Linked issues: dashpay#68 dashpay#136 ACKs for top commit: hebasto: re-ACK dc4551c jarolrod: ACK dc4551c Tree-SHA512: 1c3a4dec796063e61fcaf80112afc2b15c8669a1cd30ebd537cea96647c20215f8f80289719f905820bb0c490c8c1f94bfae4bb32f9c6d1fdd4e8f199ebb559f
1 parent 5faf781 commit 36b7a7c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

doc/release-notes-154.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Compatibility
2+
==============
3+
4+
Dash Core change appearance when macOS "dark mode" is activated.

share/qt/Info.plist.in

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,6 @@
5656
<key>NSHighResolutionCapable</key>
5757
<string>True</string>
5858

59-
<key>NSRequiresAquaSystemAppearance</key>
60-
<string>True</string>
61-
6259
<key>NSHumanReadableCopyright</key>
6360
<string>Copyright © 2009-@COPYRIGHT_YEAR@ The Bitcoin Core developers, 2014-@COPYRIGHT_YEAR@ @COPYRIGHT_HOLDERS_FINAL@</string>
6461
<key>LSApplicationCategoryType</key>

0 commit comments

Comments
 (0)