Fix mktemp --dry-run not creating temp directory in generate-ta-tasks.sh

mktemp --dry-run only prints a candidate path without creating it,
causing go install/build to fail. Use mktemp -d to actually create the
directory, and move the cleanup trap before usage so it fires on early
failures.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Martin Basti <mbasti@redhat.com>

Author: Martin Basti

hack/generate-ta-tasks.sh

@@ -20,7 +20,8 @@ ROOT_DIR="$(git rev-parse --show-toplevel)"
 TASK_DIR="$(realpath "${ROOT_DIR}/task")"
 : "${TRUSTED_ARTIFACTS=github.com/konflux-ci/build-definitions/task-generator/trusted-artifacts@latest}"
 
-tashdir="$(mktemp --dry-run)"
+tashdir="$(mktemp -d)"
+trap 'rm -rf "${tashdir}"' EXIT
 if [[ -d "${TRUSTED_ARTIFACTS}" ]]; then
     tashbin=${tashdir}/trusted-artifacts
     GOTOOLCHAIN=auto GOSUMDB=sum.golang.org go build -C "${TRUSTED_ARTIFACTS}" -o "${tashbin}"
@@ -33,7 +34,6 @@ else
     fi
     tashbin=${bin[0]}
 fi
-trap 'rm -r "${tashdir}"' EXIT
 
 tash() {
   "${tashbin}" "$@"

{{cookiecutter.repo_root}}/hack/generate-ta-tasks.sh

@@ -20,7 +20,8 @@ ROOT_DIR="$(git rev-parse --show-toplevel)"
 TASK_DIR="$(realpath "${ROOT_DIR}/task")"
 : "${TRUSTED_ARTIFACTS=github.com/konflux-ci/build-definitions/task-generator/trusted-artifacts@latest}"
 
-tashdir="$(mktemp --dry-run)"
+tashdir="$(mktemp -d)"
+trap 'rm -rf "${tashdir}"' EXIT
 if [[ -d "${TRUSTED_ARTIFACTS}" ]]; then
     tashbin=${tashdir}/trusted-artifacts
     GOTOOLCHAIN=auto GOSUMDB=sum.golang.org go build -C "${TRUSTED_ARTIFACTS}" -o "${tashbin}"
@@ -33,7 +34,6 @@ else
     fi
     tashbin=${bin[0]}
 fi
-trap 'rm -r "${tashdir}"' EXIT
 
 tash() {
   "${tashbin}" "$@"