Skip to content

Commit b9e765d

Browse files
committed
fix: update ut comments for coscheduling.
Signed-off-by: Asklv <boironic@gmail.com>
1 parent 8382566 commit b9e765d

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

pkg/runtime/framework/plugins/coscheduling/coscheduling_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@ func TestCoScheduling(t *testing.T) {
386386
},
387387
wantBuildError: errorGetPodGroup,
388388
},
389-
"no action when PodGroup already exists": {
389+
"no action when PodGroup already exists and TrainJob is not suspended": {
390390
info: &runtime.Info{
391391
Scheduler: &runtime.Scheduler{},
392392
Labels: map[string]string{"key": "value"},
@@ -438,7 +438,7 @@ func TestCoScheduling(t *testing.T) {
438438
wantPodGroupPolicyError: nil,
439439
wantBuildError: nil,
440440
},
441-
"no action when TrainJob is suspended": {
441+
"no action when TrainJob is not suspended": {
442442
info: &runtime.Info{
443443
Scheduler: &runtime.Scheduler{},
444444
RuntimePolicy: runtime.RuntimePolicy{
@@ -574,7 +574,7 @@ func TestCoScheduling(t *testing.T) {
574574
}
575575

576576
var objs []any
577-
objs, err = plugin.(framework.ComponentBuilderPlugin).Build(context.Background(), tc.info, tc.trainJob)
577+
objs, err = plugin.(framework.ComponentBuilderPlugin).Build(ctx, tc.info, tc.trainJob)
578578
if diff := gocmp.Diff(tc.wantBuildError, err, cmpopts.EquateErrors()); len(diff) != 0 {
579579
t.Errorf("Unexpected error from Build (-want, +got): %s", diff)
580580
}

0 commit comments

Comments
 (0)