Enable Rollback Support of VAC with Infeasible Errors #487

sunnylovestiramisu · 2025-03-21T20:41:42Z

What type of PR is this?
/kind feature

What this PR does / why we need it:
ControllerModifyVolume should allow rollback if a modification ends in infeasible state.

Google doc VolumeAttributesClass Recovery Support

Which issue(s) this PR fixes:
Fixes #482 , kubernetes/kubernetes#130597

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Enable Rollback Support of VAC with Infeasible Errors

xing-yang · 2025-03-27T01:16:38Z

/lgtm

pkg/modifycontroller/modify_volume.go

k8s-ci-robot · 2025-05-28T22:02:55Z

New changes are detected. LGTM label has been removed.

k8s-ci-robot · 2025-05-28T22:02:59Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunnylovestiramisu
Once this PR has been reviewed and has the lgtm label, please ask for approval from xing-yang. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gnufied · 2025-05-29T19:59:37Z

pkg/modifycontroller/modify_volume.go

@@ -67,6 +67,16 @@ func (ctrl *modifyController) modify(pvc *v1.PersistentVolumeClaim, pv *v1.Persi
 		}
 	}

+	// Rollback infeasible errors for recovery
+	if pvc.Status.ModifyVolumeStatus != nil && pvc.Status.ModifyVolumeStatus.Status == v1.PersistentVolumeClaimModifyVolumeInfeasible {


So I personally like large conditions like these to be behind functions which I can readily understand when reading this code again. I made a refactor of this - gnufied@fa37fc1 would you consider pulling this in?

Yes! Let me update the PR and ping you again when tests pass etc.

Added in this commit: ac09a30

AndrewSirenko · 2025-05-30T16:40:15Z

pkg/modifycontroller/modify_volume.go

+	// Rollback infeasible errors for recovery
+	if pvc.Status.ModifyVolumeStatus != nil && pvc.Status.ModifyVolumeStatus.Status == v1.PersistentVolumeClaimModifyVolumeInfeasible {
+		targetVacName := pvc.Status.ModifyVolumeStatus.TargetVolumeAttributesClassName
+		// Case 1: rollback to nil


Was trying to manually test case 1 alongside EBS CSI Driver, but looks like k/k API PVC Spec validation is getting in the way of setting `PVC.VACName = "":

❯ ka . storageclass.storage.k8s.io/ebs-sc created persistentvolumeclaim/ebs-claim created pod/app created volumeattributesclass.storage.k8s.io/io2-class created volumeattributesclass.storage.k8s.io/io3-class unchanged ❯ k patch pvc ebs-claim --patch '{"spec": {"volumeAttributesClassName": "io3-class"}}' persistentvolumeclaim/ebs-claim patched ❯ k describe pvc Name: ebs-claim ... Normal VolumeModify 23s external-resizer ebs.csi.aws.com external resizer is modifying volume ebs-claim with vac io3-class Warning VolumeModifyFailed 20s external-resizer ebs.csi.aws.com rpc error: code = InvalidArgument desc ... ❯ k patch pvc ebs-claim --patch '{"spec": {"volumeAttributesClassName": ""}}' The PersistentVolumeClaim "ebs-claim" is invalid: spec.volumeAttributesClassName: Forbidden: update from non-nil value to an empty string is forbidden

We would have to remove the following validations on PVC and PV specs in kubernetes/pkg/apis/core/validation/validation.go at master · kubernetes/kubernetes:

len(pvc.spec.VACName) > 0 https://github.com/kubernetes/kubernetes/blob/02eb7d424ad5ccf4f00863fe861f165be0d491da/pkg/apis/core/validation/validation.go#L2381

Might also have to remove - len(pvSpec.VACName) == 0 https://github.com/kubernetes/kubernetes/blob/02eb7d424ad5ccf4f00863fe861f165be0d491da/pkg/apis/core/validation/validation.go#L2109-L2111

This PR might still be fine. If you wish I can test this resizer against a modified k/k, and then raise PR for the API validation changes.

We are going to change validations, we might be in trouble wrt to moving feature GA in this release.

VAC name in PVC spec is a pointer to string. It can be nil, but it cannot be an empty string:
https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/types.go#L403

// Name of VolumeAttributesClass to which this persistent volume belongs. Empty value is not allowed ...... VolumeAttributesClassName *string

In the code, it is possible to reset it to nil again.
We should not allow user to set VAC name to an empty string. It is not allowed by the API.

@AndrewSirenko Can you test it by removing "VolumeAttributesClassName" from the PVC spec? It is an optional field.

@xing-yang This time I used kubectl edit to either delete the line volumeAttributesClassName: io3-class OR set it to the yaml indicator for nil volumeAttributesClassName: ~

Both times I get 14 # * spec.volumeAttributesClassName: Forbidden: update from non-nil value to nil is forbidden

Now I explicitly try to patch as well:

❯ k patch pvc ebs-claim --type=merge -p '{"spec":{"VolumeAttributesClassName": null}}' persistentvolumeclaim/ebs-claim patched (no change) ❯ k get pvc -o yaml .... spec: volumeAttributesClassName: io3-class ... type: ModifyingVolume modifyVolumeStatus: status: Infeasible targetVolumeAttributesClassName: io3-class phase: Bound

I believe this "cannot update non-nil to nil" is due to the following validation: https://github.com/kubernetes/kubernetes/blob/02eb7d424ad5ccf4f00863fe861f165be0d491da/pkg/apis/core/validation/validation.go#L2461-L2464

if oldPvc.Spec.VolumeAttributesClassName != nil { if newPvc.Spec.VolumeAttributesClassName == nil { allErrs = append(allErrs, field.Forbidden(field.NewPath("spec", "volumeAttributesClassName"), "update from non-nil value to nil is forbidden")) } else if len(*newPvc.Spec.VolumeAttributesClassName) == 0 { allErrs = append(allErrs, field.Forbidden(field.NewPath("spec", "volumeAttributesClassName"), "update from non-nil value to an empty string is forbidden")) }

I wonder if it is possible to allow this only during a rollback. If VAC name is set to a non-nil value successfully, maybe we should not allow user to change it back to nil.

Note for future reviewers

More discussion on k/k slack here: https://kubernetes.slack.com/archives/C8EJ01Z46/p1748628161127689

See pr here: Allow PVC VACName to go from non-nil to nil

AndrewSirenko · 2025-05-30T16:49:22Z

pkg/modifycontroller/modify_volume.go

+	// for rollbacking infeasible errors
+	// Record an event to indicate that external resizer is rolling back this volume.
+	ctrl.eventRecorder.Event(pvc, v1.EventTypeNormal, util.VolumeModify,
+		fmt.Sprintf("external resizer is rolling back volume %s with infeasible error", pvc.Name))


Opinion: Thoughts on explicitly mentioning VAC name in event message? Something like "external resizer is rolling back volume with infeasible error to VAC "

Might be nice for those retro-actively auditing PVC events.

Added in this commit: ac09a30

AndrewSirenko · 2025-05-30T16:54:33Z

Manually tested both cases alongside AWS EBS CSI Driver v1.44 on Kubernetes v1.33.

Rollback from VAC B to VAC A works great: https://gist.github.com/AndrewSirenko/22f62e64e604bc00cf2373aa4b2a0f4e

Couldn't test rollback to no VAC because turns out we validate pvc.spec.VACName to not be len 0 :/. See comment #487 (comment)

Will build k/k without those validations and retest this PR against that cluster next week.

sunnylovestiramisu · 2025-05-30T23:16:56Z

/retest

AndrewSirenko · 2025-06-04T20:50:04Z

pkg/modifycontroller/modify_volume.go

+	pvcSpecVacName := pvc.Spec.VolumeAttributesClassName
+	curVacName := pvc.Status.CurrentVolumeAttributesClassName
+	targetVacName := pvc.Status.ModifyVolumeStatus.TargetVolumeAttributesClassName
+	// Case 1: rollback to nil


Infeasible condition and targetVacName not being cleared in case 1.

After updating kube-api-server to loosen PVC (and PV) Update validation, I am able to make PVC.spec.Vacname nil, but conditions and targetVacName not being cleared.

❯ k patch pvc ebs-claim --patch '{"spec": {"volumeAttributesClassName": "io3-class"}}' persistentvolumeclaim/ebs-claim patched ❯ k get pvc -o yaml spec: storageClassName: ebs-sc volumeAttributesClassName: io3-class volumeMode: Filesystem volumeName: pvc-e6c5e8ea-c220-4c59-8162-3ef63c3fb02f status: accessModes: - ReadWriteOnce capacity: storage: 10Gi conditions: - lastProbeTime: null lastTransitionTime: "2025-06-04T20:46:21Z" message: ModifyVolume operation in progress. status: "True" type: ModifyingVolume modifyVolumeStatus: status: InProgress targetVolumeAttributesClassName: io3-class phase: Bound kind: List metadata: resourceVersion: "" ❯ k patch pvc ebs-claim --patch '{"spec": {"volumeAttributesClassName": null}}' persistentvolumeclaim/ebs-claim patched ❯ k get pvc -o yaml ... spec: storageClassName: ebs-sc volumeMode: Filesystem volumeName: pvc-e6c5e8ea-c220-4c59-8162-3ef63c3fb02f status: accessModes: - ReadWriteOnce capacity: storage: 10Gi conditions: - lastProbeTime: null lastTransitionTime: "2025-06-04T20:46:24Z" message: 'ModifyVolume failed with errorrpc error: code = InvalidArgument desc = Could not modify volume (invalid argument) "vol-0a79bd36e00ed821d": invalid argument: operation error EC2: ModifyVolume, https response error StatusCode: 400, RequestID: 9de7e3e3-c512-4004-958f-6a83c9ed791c, api error UnknownVolumeType: Unsupported volume type ''io3'' for volume creation. . Waiting for retry.' status: "True" type: ModifyingVolume modifyVolumeStatus: status: Infeasible targetVolumeAttributesClassName: io3-class phase: Bound kind: List metadata: resourceVersion: ""

Case 2 is still fine.

See gist for longer example: K/K VAC Validation changes + Sunny's resizer PR

Will link k/k validation pr shortly.

Works with commit 9daca! Tested on cluster with api server built from kubernetes/kubernetes#132106 and EBS CSI Driver + resizer built from this commit

Proof:

❯ ka examples/kubernetes/modify-volume/manifests Warning: storage.k8s.io/v1beta1 VolumeAttributesClass is deprecated in v1.34+, unavailable in v1.37+ volumeattributesclass.storage.k8s.io/io3-class created storageclass.storage.k8s.io/ebs-sc created persistentvolumeclaim/ebs-claim created pod/app created volumeattributesclass.storage.k8s.io/io2-class created ❯ k patch pvc ebs-claim --patch '{"spec": {"volumeAttributesClassName": "io3-class"}}' persistentvolumeclaim/ebs-claim patched ❯ k describe pvc Name: ebs-claim Namespace: default StorageClass: ebs-sc Status: Bound Volume: pvc-4cbbe0a7-acb4-4b99-ab9c-161848377cf3 Labels: <none> Annotations: pv.kubernetes.io/bind-completed: yes pv.kubernetes.io/bound-by-controller: yes volume.beta.kubernetes.io/storage-provisioner: ebs.csi.aws.com volume.kubernetes.io/selected-node: i-0d40f496eeab7c80c volume.kubernetes.io/storage-provisioner: ebs.csi.aws.com Finalizers: [kubernetes.io/pvc-protection] Capacity: 10Gi Access Modes: RWO VolumeMode: Filesystem Used By: app Conditions: Type Status LastProbeTime LastTransitionTime Reason Message ---- ------ ----------------- ------------------ ------ ------- ModifyingVolume True Mon, 01 Jan 0001 00:00:00 +0000 Tue, 15 Jul 2025 21:32:25 +0000 ModifyVolume failed with errorrpc error: code = InvalidArgument desc = Could not modify volume (invalid argument) "vol-071a09677ddaa352e": invalid argument: operation error EC2: ModifyVolume, https response error StatusCode: 400, RequestID: 2742eb7a-c695-4fb7-90fd-085d2990537c, api error UnknownVolumeType: Unsupported volume type 'io3' for volume creation. . Waiting for retry. Events: Type Reason Age From Message ---- ------ ---- ---- ------- Normal WaitForFirstConsumer 21s persistentvolume-controller waiting for first consumer to be created before binding Normal Provisioning 21s ebs.csi.aws.com_ebs-csi-controller-b4fcfd4db-5dp4t_b0c389e3-afe9-4ed5-9c4e-e2d61d19c640 External provisioner is provisioning volume for claim "default/ebs-claim" Normal ExternalProvisioning 21s persistentvolume-controller Waiting for a volume to be created either by the external provisioner 'ebs.csi.aws.com' or manually by the system administrator. If volume creation is delayed, please verify that the provisioner is running and correctly registered. Normal ProvisioningSucceeded 18s ebs.csi.aws.com_ebs-csi-controller-b4fcfd4db-5dp4t_b0c389e3-afe9-4ed5-9c4e-e2d61d19c640 Successfully provisioned volume pvc-4cbbe0a7-acb4-4b99-ab9c-161848377cf3 Normal VolumeModify 4s external-resizer ebs.csi.aws.com external resizer is modifying volume ebs-claim with vac io3-class Warning VolumeModifyFailed 1s external-resizer ebs.csi.aws.com rpc error: code = InvalidArgument desc = Could not modify volume (invalid argument) "vol-071a09677ddaa352e": invalid argument: operation error EC2: ModifyVolume, https response error StatusCode: 400, RequestID: 2742eb7a-c695-4fb7-90fd-085d2990537c, api error UnknownVolumeType: Unsupported volume type 'io3' for volume creation. ❯ k get pvc -o yaml apiVersion: v1 items: - apiVersion: v1 kind: PersistentVolumeClaim metadata: annotations: kubectl.kubernetes.io/last-applied-configuration: | {"apiVersion":"v1","kind":"PersistentVolumeClaim","metadata":{"annotations":{},"name":"ebs-claim","namespace":"default"},"spec":{"accessModes":["ReadWriteOnce"],"resources":{"requests":{"storage":"10Gi"}},"storageClassName":"ebs-sc"}} pv.kubernetes.io/bind-completed: "yes" pv.kubernetes.io/bound-by-controller: "yes" volume.beta.kubernetes.io/storage-provisioner: ebs.csi.aws.com volume.kubernetes.io/selected-node: i-0d40f496eeab7c80c volume.kubernetes.io/storage-provisioner: ebs.csi.aws.com creationTimestamp: "2025-07-15T21:32:05Z" finalizers: - kubernetes.io/pvc-protection name: ebs-claim namespace: default resourceVersion: "6096" uid: 4cbbe0a7-acb4-4b99-ab9c-161848377cf3 spec: accessModes: - ReadWriteOnce resources: requests: storage: 10Gi storageClassName: ebs-sc volumeAttributesClassName: io3-class volumeMode: Filesystem volumeName: pvc-4cbbe0a7-acb4-4b99-ab9c-161848377cf3 status: accessModes: - ReadWriteOnce capacity: storage: 10Gi conditions: - lastProbeTime: null lastTransitionTime: "2025-07-15T21:32:25Z" message: 'ModifyVolume failed with errorrpc error: code = InvalidArgument desc = Could not modify volume (invalid argument) "vol-071a09677ddaa352e": invalid argument: operation error EC2: ModifyVolume, https response error StatusCode: 400, RequestID: 2742eb7a-c695-4fb7-90fd-085d2990537c, api error UnknownVolumeType: Unsupported volume type ''io3'' for volume creation. . Waiting for retry.' status: "True" type: ModifyingVolume modifyVolumeStatus: status: Infeasible targetVolumeAttributesClassName: io3-class phase: Bound kind: List metadata: resourceVersion: "" ❯ k patch pvc ebs-claim --patch '{"spec": {"volumeAttributesClassName": null}}' persistentvolumeclaim/ebs-claim patched ❯ k describe pvc Name: ebs-claim Namespace: default StorageClass: ebs-sc Status: Bound Volume: pvc-4cbbe0a7-acb4-4b99-ab9c-161848377cf3 Labels: <none> Annotations: pv.kubernetes.io/bind-completed: yes pv.kubernetes.io/bound-by-controller: yes volume.beta.kubernetes.io/storage-provisioner: ebs.csi.aws.com volume.kubernetes.io/selected-node: i-0d40f496eeab7c80c volume.kubernetes.io/storage-provisioner: ebs.csi.aws.com Finalizers: [kubernetes.io/pvc-protection] Capacity: 10Gi Access Modes: RWO VolumeMode: Filesystem Used By: app Events: Type Reason Age From Message ---- ------ ---- ---- ------- Normal WaitForFirstConsumer 57s persistentvolume-controller waiting for first consumer to be created before binding Normal Provisioning 57s ebs.csi.aws.com_ebs-csi-controller-b4fcfd4db-5dp4t_b0c389e3-afe9-4ed5-9c4e-e2d61d19c640 External provisioner is provisioning volume for claim "default/ebs-claim" Normal ExternalProvisioning 57s persistentvolume-controller Waiting for a volume to be created either by the external provisioner 'ebs.csi.aws.com' or manually by the system administrator. If volume creation is delayed, please verify that the provisioner is running and correctly registered. Normal ProvisioningSucceeded 54s ebs.csi.aws.com_ebs-csi-controller-b4fcfd4db-5dp4t_b0c389e3-afe9-4ed5-9c4e-e2d61d19c640 Successfully provisioned volume pvc-4cbbe0a7-acb4-4b99-ab9c-161848377cf3 Normal VolumeModify 40s external-resizer ebs.csi.aws.com external resizer is modifying volume ebs-claim with vac io3-class Warning VolumeModifyFailed 37s external-resizer ebs.csi.aws.com rpc error: code = InvalidArgument desc = Could not modify volume (invalid argument) "vol-071a09677ddaa352e": invalid argument: operation error EC2: ModifyVolume, https response error StatusCode: 400, RequestID: 2742eb7a-c695-4fb7-90fd-085d2990537c, api error UnknownVolumeType: Unsupported volume type 'io3' for volume creation. Normal VolumeModify 6s external-resizer ebs.csi.aws.com external resizer is rolling back volume ebs-claim with infeasible error to VAC nil ❯ k get pvc -o yaml apiVersion: v1 items: - apiVersion: v1 kind: PersistentVolumeClaim metadata: annotations: kubectl.kubernetes.io/last-applied-configuration: | {"apiVersion":"v1","kind":"PersistentVolumeClaim","metadata":{"annotations":{},"name":"ebs-claim","namespace":"default"},"spec":{"accessModes":["ReadWriteOnce"],"resources":{"requests":{"storage":"10Gi"}},"storageClassName":"ebs-sc"}} pv.kubernetes.io/bind-completed: "yes" pv.kubernetes.io/bound-by-controller: "yes" volume.beta.kubernetes.io/storage-provisioner: ebs.csi.aws.com volume.kubernetes.io/selected-node: i-0d40f496eeab7c80c volume.kubernetes.io/storage-provisioner: ebs.csi.aws.com creationTimestamp: "2025-07-15T21:32:05Z" finalizers: - kubernetes.io/pvc-protection name: ebs-claim namespace: default resourceVersion: "6213" uid: 4cbbe0a7-acb4-4b99-ab9c-161848377cf3 spec: accessModes: - ReadWriteOnce resources: requests: storage: 10Gi storageClassName: ebs-sc volumeMode: Filesystem volumeName: pvc-4cbbe0a7-acb4-4b99-ab9c-161848377cf3 status: accessModes: - ReadWriteOnce capacity: storage: 10Gi phase: Bound kind: List metadata: resourceVersion: ""

AndrewSirenko · 2025-07-17T20:30:48Z

pkg/modifycontroller/modify_status.go

+
+	// Update PV
+	newPV := pv.DeepCopy()
+	newPV.Spec.VolumeAttributesClassName = pvc.Spec.VolumeAttributesClassName


Because API Server prohibits PV.Spec.VACName to be empty string, we must guard against case PVC.spec.VACName="" and set PV.VACName to nil in that case

Discussed https://kubernetes.slack.com/archives/C09QZFCE5/p1752777281020219

AndrewSirenko · 2025-07-17T21:09:27Z

pkg/modifycontroller/modify_volume_test.go

+			expectedPVVolumeAttributesClassName:      &testVac,
+		},
+		{
+			name:                                     "modify volume rollback to nil succeeds for infeasible errors",


Should we add a modify volume to empty string rollback succeeds unit test just to be safe in case someone forgets PV.Spev.VACName must not be empty string?

Yes, I am planning to, but just updating the PR to test k/k change first.

Added test case, and the expectedPVVolumeAttributesClassName is nil.

AndrewSirenko · 2025-07-17T21:21:55Z

Works alongside Allow PVC VACName to go from non-nil to nil!

Proof: Success: Nil VAC -> Infeasible VAC -> emptystring VACName

gnufied · 2025-07-18T23:58:05Z

pkg/modifycontroller/modify_status.go

@@ -73,6 +74,44 @@ func (ctrl *modifyController) markControllerModifyVolumeStatus(
 	return updatedPVC, nil
 }

+func (ctrl *modifyController) markCotrollerModifyVolumeRollbackCompeleted(


typo in markController btw.

k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 21, 2025

k8s-ci-robot requested review from carlory and chrishenzie March 21, 2025 20:41

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 21, 2025

sunnylovestiramisu requested review from gnufied and AndrewSirenko March 21, 2025 20:43

sunnylovestiramisu force-pushed the fixVacBeforeGA branch from 0a9dc85 to 20411cf Compare March 21, 2025 21:02

sunnylovestiramisu removed the request for review from chrishenzie March 21, 2025 21:03

sunnylovestiramisu force-pushed the fixVacBeforeGA branch from 20411cf to 5cc5fe8 Compare March 21, 2025 21:06

k8s-ci-robot assigned xing-yang Mar 27, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2025

gnufied reviewed Mar 31, 2025

View reviewed changes

pkg/modifycontroller/modify_volume.go Outdated Show resolved Hide resolved

carlory mentioned this pull request Apr 30, 2025

[Kep-3751] Promote VolumeAttributesClass to GA kubernetes/kubernetes#131549

Open

sunnylovestiramisu force-pushed the fixVacBeforeGA branch from 5cc5fe8 to 8b9a874 Compare May 28, 2025 22:02

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2025

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 28, 2025

sunnylovestiramisu force-pushed the fixVacBeforeGA branch 2 times, most recently from fffb062 to feae994 Compare May 28, 2025 22:59

gnufied reviewed May 29, 2025

View reviewed changes

AndrewSirenko reviewed May 30, 2025

View reviewed changes

sunnylovestiramisu force-pushed the fixVacBeforeGA branch from feae994 to ac09a30 Compare May 30, 2025 22:39

AndrewSirenko reviewed Jun 4, 2025

View reviewed changes

This was referenced Jun 4, 2025

Allow PVC VACName to go from non-nil to nil kubernetes/kubernetes#132106

Open

Kubernetes VolumeAttributesClass ModifyVolume kubernetes/enhancements#3751

Open

sunnylovestiramisu force-pushed the fixVacBeforeGA branch from ac09a30 to 9dacaa9 Compare July 9, 2025 19:24

AndrewSirenko reviewed Jul 17, 2025

View reviewed changes

sunnylovestiramisu force-pushed the fixVacBeforeGA branch from 9dacaa9 to 471edad Compare July 17, 2025 20:42

AndrewSirenko reviewed Jul 17, 2025

View reviewed changes

sunnylovestiramisu force-pushed the fixVacBeforeGA branch from 471edad to 58d8381 Compare July 17, 2025 21:16

sunnylovestiramisu force-pushed the fixVacBeforeGA branch from 58d8381 to 42bb9bf Compare July 17, 2025 21:57

Enable Rollback Support of VAC with Infeasible Errors

92a872b

sunnylovestiramisu force-pushed the fixVacBeforeGA branch from 42bb9bf to 92a872b Compare July 17, 2025 22:07

gnufied reviewed Jul 18, 2025

View reviewed changes

Enable Rollback Support of VAC with Infeasible Errors #487

Are you sure you want to change the base?

Enable Rollback Support of VAC with Infeasible Errors #487

Uh oh!

Conversation

sunnylovestiramisu commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xing-yang commented Mar 27, 2025

Uh oh!

Uh oh!

k8s-ci-robot commented May 28, 2025

Uh oh!

k8s-ci-robot commented May 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndrewSirenko May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndrewSirenko commented May 30, 2025

Uh oh!

sunnylovestiramisu commented May 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndrewSirenko commented Jul 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sunnylovestiramisu commented Mar 21, 2025 •

edited

Loading

AndrewSirenko May 30, 2025 •

edited

Loading