Skip to content
This repository was archived by the owner on Dec 3, 2024. It is now read-only.

Commit 9acee62

Browse files
committed
update api version & glog -> klog
1 parent c357290 commit 9acee62

File tree

6 files changed

+144
-163
lines changed

6 files changed

+144
-163
lines changed

cmd/controller-manager/controller-manager.go

Lines changed: 13 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414
"github.com/kubernetes-sigs/container-object-storage-interface-controller/pkg/bucketrequest"
1515
bucketcontroller "sigs.k8s.io/container-object-storage-interface-api/controller"
1616

17-
"github.com/golang/glog"
17+
"k8s.io/klog/v2"
1818
)
1919

2020
var cmd = &cobra.Command{
@@ -29,34 +29,20 @@ var cmd = &cobra.Command{
2929
}
3030

3131
var kubeConfig string
32+
var verbosity int
3233

3334
func init() {
3435
viper.AutomaticEnv()
3536

36-
cmd.PersistentFlags().AddGoFlagSet(flag.CommandLine)
37-
flag.Set("logtostderr", "true")
38-
39-
strFlag := func(c *cobra.Command, ptr *string, name string, short string, dfault string, desc string) {
40-
c.PersistentFlags().
41-
StringVarP(ptr, name, short, dfault, desc)
42-
}
43-
strFlag(cmd, &kubeConfig, "kubeconfig", "", kubeConfig, "path to kubeconfig file")
44-
45-
hideFlag := func(name string) {
46-
cmd.PersistentFlags().MarkHidden(name)
47-
}
48-
hideFlag("alsologtostderr")
49-
hideFlag("log_backtrace_at")
50-
hideFlag("log_dir")
51-
hideFlag("logtostderr")
52-
hideFlag("master")
53-
hideFlag("stderrthreshold")
54-
hideFlag("vmodule")
55-
56-
// suppress the incorrect prefix in glog output
57-
flag.CommandLine.Parse([]string{})
37+
flag.Set("alsologtostderr", "true")
38+
kflags := flag.NewFlagSet("klog", flag.ExitOnError)
39+
klog.InitFlags(kflags)
40+
41+
cmd.PersistentFlags().AddGoFlagSet(kflags)
42+
cmd.PersistentFlags().StringVarP(&kubeConfig, "kubeconfig", "", kubeConfig, "path to kubeconfig file")
43+
44+
//flag.CommandLine.Parse([]string{})
5845
viper.BindPFlags(cmd.PersistentFlags())
59-
6046
}
6147

6248
func main() {
@@ -72,16 +58,16 @@ func main() {
7258
}()
7359

7460
if err := cmd.ExecuteContext(ctx); err != nil {
75-
glog.Fatal(err.Error())
61+
klog.Error(err)
7662
}
7763
}
7864

7965
func run(ctx context.Context, args []string) error {
80-
ctrl, err := bucketcontroller.NewDefaultObjectStorageController("controller-manager", "leader-lock", 40)
66+
ctrl, err := bucketcontroller.NewDefaultObjectStorageController("cosi-controller-manager", "leader-lock", 40)
8167
if err != nil {
8268
return err
8369
}
84-
ctrl.AddBucketRequestListener(bucketrequest.NewListener())
70+
ctrl.AddBucketRequestListener(bucketrequest.NewBucketRequestListener())
8571
ctrl.AddBucketAccessRequestListener(bucketaccessrequest.NewListener())
8672
return ctrl.Run(ctx)
8773
}

go.mod

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,7 @@ module github.com/kubernetes-sigs/container-object-storage-interface-controller
33
go 1.15
44

55
require (
6-
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
7-
github.com/golang/protobuf v1.4.3 // indirect
86
github.com/google/go-cmp v0.5.2 // indirect
9-
github.com/google/uuid v1.1.2 // indirect
107
github.com/gopherjs/gopherjs v0.0.0-20190328170749-bb2674552d8f // indirect
118
github.com/kr/text v0.2.0 // indirect
129
github.com/mailru/easyjson v0.7.6 // indirect
@@ -29,8 +26,8 @@ require (
2926
k8s.io/apiextensions-apiserver v0.19.4
3027
k8s.io/apimachinery v0.19.4
3128
k8s.io/client-go v0.19.4
32-
k8s.io/klog/v2 v2.4.0 // indirect
29+
k8s.io/klog/v2 v2.4.0
3330
k8s.io/kube-openapi v0.0.0-20201113171705-d219536bb9fd // indirect
34-
sigs.k8s.io/container-object-storage-interface-api v0.0.0-20210225042325-7c26b4fc1ed9
31+
sigs.k8s.io/container-object-storage-interface-api v0.0.0-20210315005104-5e1814a6aedd
3532
sigs.k8s.io/controller-tools v0.4.1
3633
)

0 commit comments

Comments
 (0)