fix: set machine fd string if not defined

This commit sets the `machine.Spec.FailureDomain` string
from the `vsphereMachine.Spec.FailureDomain` if
defined and the machine failure domain is empty.

This resolves an issue where virtual machines are not placed
within vm-host groups in a timely
manner causing misplacement in the topology.

Author: jcpowermac

controllers/vspherevm_controller.go

@@ -233,6 +233,12 @@ func (r vmReconciler) Reconcile(ctx context.Context, req ctrl.Request) (_ ctrl.R
 		return ctrl.Result{}, err
 	}
 
+	if vsphereMachine.Spec.FailureDomain != nil && *vsphereMachine.Spec.FailureDomain != "" {
+		if machine.Spec.FailureDomain == "" {
+			machine.Spec.FailureDomain = *vsphereMachine.Spec.FailureDomain
+		}
+	}
+
 	var vsphereFailureDomain *infrav1.VSphereFailureDomain
 	if failureDomain := machine.Spec.FailureDomain; failureDomain != "" {
 		vsphereDeploymentZone := &infrav1.VSphereDeploymentZone{}