Skip to content

Commit 3c74681

Browse files
committed
refactor(fake-client): update json-patch dependency to v5
update the json-patch dependency from v4 to v5 in the fake client implementation. This change aligns the dependency with its latest version in the `github.com/evanphx/json-patch` package. also, fix a minor formatting issue in a TODO comment for consistency.
1 parent b68a062 commit 3c74681

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ require (
2020
golang.org/x/sync v0.10.0
2121
golang.org/x/sys v0.28.0
2222
gomodules.xyz/jsonpatch/v2 v2.4.0
23-
gopkg.in/evanphx/json-patch.v4 v4.12.0 // Using v4 to match upstream
2423
k8s.io/api v0.33.0-alpha.1
2524
k8s.io/apiextensions-apiserver v0.33.0-alpha.1
2625
k8s.io/apimachinery v0.33.0-alpha.1
@@ -87,6 +86,7 @@ require (
8786
google.golang.org/genproto/googleapis/rpc v0.0.0-20240826202546-f6391c0de4c7 // indirect
8887
google.golang.org/grpc v1.65.0 // indirect
8988
google.golang.org/protobuf v1.35.1 // indirect
89+
gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect
9090
gopkg.in/inf.v0 v0.9.1 // indirect
9191
gopkg.in/yaml.v3 v3.0.1 // indirect
9292
k8s.io/component-base v0.33.0-alpha.1 // indirect

pkg/client/fake/client.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@ import (
2929
"sync"
3030
"time"
3131

32-
// Using v4 to match upstream
33-
jsonpatch "gopkg.in/evanphx/json-patch.v4"
32+
jsonpatch "github.com/evanphx/json-patch/v5"
3433
appsv1 "k8s.io/api/apps/v1"
3534
authenticationv1 "k8s.io/api/authentication/v1"
3635
autoscalingv1 "k8s.io/api/autoscaling/v1"
@@ -1138,7 +1137,7 @@ func (c *fakeClient) deleteObjectLocked(gvr schema.GroupVersionResource, accesso
11381137
}
11391138
}
11401139

1141-
//TODO: implement propagation
1140+
// TODO: implement propagation
11421141
return c.tracker.Delete(gvr, accessor.GetNamespace(), accessor.GetName())
11431142
}
11441143

0 commit comments

Comments
 (0)