Merge pull request #2527 from 0xff-dev/main

k8s-ci-robot · web-flow · commit d94cf60e9e96 · 2023-10-08T02:36:10.000+02:00
🐛 fix: goroutine leak
diff --git a/pkg/manager/manager.go b/pkg/manager/manager.go
@@ -409,7 +409,7 @@ func New(config *rest.Config, options Options) (Manager, error) {
 		return nil, fmt.Errorf("failed to new pprof listener: %w", err)
 	}
 
-	errChan := make(chan error)
+	errChan := make(chan error, 1)
 	runnables := newRunnables(options.BaseContext, errChan)
 	return &controllerManager{
 		stopProcedureEngaged:          pointer.Int64(0),

Original file line number	Diff line number	Diff line change
`@@ -409,7 +409,7 @@ func New(config *rest.Config, options Options) (Manager, error) {`
`409`	`409`	`return nil, fmt.Errorf("failed to new pprof listener: %w", err)`
`410`	`410`	`}`
`411`	`411`
`412`		`- errChan := make(chan error)`
	`412`	`+ errChan := make(chan error, 1)`
`413`	`413`	`runnables := newRunnables(options.BaseContext, errChan)`
`414`	`414`	`return &controllerManager{`
`415`	`415`	`stopProcedureEngaged: pointer.Int64(0),`