-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Noisy errors in leader election lease type registration in scheme #2378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Adding the types by default sounds like a good improvement? wdyt @alvaroaleman |
Yeah, adding these when leader election is enabled or using a distinct leader election scheme with these two makes sense |
Sounds fine |
/kind feature Has this been added by default? Are we planning on registering |
Hasn't been done yet. I think Alvaro's suggestion sounds fine. Especially now that the leader election lib we use only supports leases |
Uh oh!
There was an error while loading. Please reload this page.
Version: v0.7.2.
I have a controller where I don't have
corev1
(ConfigMap) orcoordinationv1
(Lease) packages registered to thescheme
. When the controller starts up with leader election enabled with fairly standard settings, it:no kind is registered for the type v1.ConfigMap in scheme
(or...v1.Lease...
)Assuming these errors are rather harmless as the program functions, and adding this fixes the problem:
I wonder if enabling the leader election should automatically add these types to the scheme?
Manager configuration
mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{ Scheme: scheme, MetricsBindAddress: "0", SyncPeriod: flResyncPeriod, LeaderElection: *flEnableLeaderElection, LeaderElectionNamespace: *flLeaderElectionLockNamespace, LeaderElectionID: *flLeaderElectionLockName, })
Full error:
The text was updated successfully, but these errors were encountered: