You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there any reason not to combine metav1.Object and runtime.Object into a single MetaV1RuntimeObject interface?
type MetaV1RuntimeObject interface {
metav1.Object
runtime.Object
}
SetControllerReference is casting a metav1.Object into a runtime.Object which means that if this fails it will fail at run time instead of compile time.
Is there any reason not to combine
metav1.Object
andruntime.Object
into a singleMetaV1RuntimeObject
interface?SetControllerReference
is casting ametav1.Object
into aruntime.Object
which means that if this fails it will fail at run time instead of compile time.https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/controller/controllerutil/controllerutil.go#L57-L89
would be turned into
The text was updated successfully, but these errors were encountered: