contoller-gen: webhook generator support for admissionregistration.k8s.io/v1

[jiachengxu]

Hi folks,
Since admissionregistration.k8s.io/v1beta1 is deprecated in kubernetes v1.16 in favor of admissionregistration.k8s.io/v1, do you have a plan for adding support to generate webhook configurations (Validating/MutatingWebhokConfiguration) for admissionregistration.k8s.io/v1?

I can work on this if it is needed.

[aborilov]

+1

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[vincepri]

/lifecycle frozen

[vincepri]

This would be good to have, @DirectXMan12 @alvaroaleman thoughts?

[jiachengxu]

I think we can add a WebhookVersions to Webhook generator, just like what we have for CRD generator (CRDVersions): https://github.com/kubernetes-sigs/controller-tools/blob/master/pkg/crd/gen.go#L81
WDYT @vincepri ?

[vincepri]

Not sure if we have to support both of them going forward, we can make this a breaking(?) change and only generate v1 webhooks

[alvaroaleman]

Not sure if we have to support both of them going forward, we can make this a breaking(?) change and only generate v1 webhooks

Not sure if completely removing the beta support is a good idea because some cloud vendors severly lack behind in the offered kube version. What kube version is needed for the v1 webhook?

Defaulting to the newer version sgtm though

[jiachengxu]

Not sure if completely removing the beta support is a good idea because some cloud vendors severly lack behind in the offered kube version. What kube version is needed for the v1 webhook?

@alvaroaleman as mentioned here: https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#prerequisites
admissionregistration.k8s.io/v1 is only available with kubernetes v1.16+

@vincepri I also think it is better to also have v1beta1 webhook, and we default to generate the v1 version.

[jiachengxu]

/assign