Skip to content

Commit 643179c

Browse files
committed
feat(pkg/descheduler): setup prometheus client for the dry run mode descheduler as well
The secret is used for read-only operations so it can be safely wired.
1 parent d167103 commit 643179c

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

pkg/descheduler/descheduler.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -564,7 +564,7 @@ func bootstrapDescheduler(
564564
return nil, nil, fmt.Errorf("failed to create new descheduler: %v", err)
565565
}
566566

567-
// Setup Prometheus provider (only for real client case, not for dry run)
567+
// Setup Prometheus provider
568568
if err := setupPrometheusProvider(descheduler, namespacedSharedInformerFactory); err != nil {
569569
return nil, nil, fmt.Errorf("failed to setup Prometheus provider: %v", err)
570570
}
@@ -586,6 +586,11 @@ func bootstrapDescheduler(
586586
if err != nil {
587587
return nil, nil, fmt.Errorf("failed to create dry run descheduler: %v", err)
588588
}
589+
590+
// Setup Prometheus provider (with the real shared informer factory as the secret is only read)
591+
if err := setupPrometheusProvider(descheduler, namespacedSharedInformerFactory); err != nil {
592+
return nil, nil, fmt.Errorf("failed to setup Prometheus provider for the dry run descheduler: %v", err)
593+
}
589594
}
590595

591596
// init is responsible for starting all informer factories, metrics providers

0 commit comments

Comments
 (0)