e2e: add first test

with all the infrastructure in place, we can now add the first
real test. We start with the simplest case: a best effort pod
should still get access to all the CPUs.

Because we added all the infrastructure and utilities, next tests
which will be much easier to add.

Signed-off-by: Francesco Romani <fromani@redhat.com>

Author: ffromani

Makefile

@@ -130,7 +130,7 @@ test-dracpuinfo: ## build helper to expose hardware info in the internal dracpu
 	go build -v -o "$(OUT_DIR)/dracpuinfo" ./test/image/dracpuinfo
 
 test-e2e-base: ## run e2e test base suite
-	env DRACPUINFO_IMAGE="$(IMAGE_TESTING)" go test -v ./test/e2e/ --ginkgo.v
+	env DRACPU_TEST_IMAGE="$(IMAGE_TESTING)" go test -v ./test/e2e/ --ginkgo.v
 
 # dependencies
 .PHONY:

go.mod

@@ -4,6 +4,7 @@ go 1.24.0
 
 require (
 	github.com/containerd/nri v0.9.0
+	github.com/go-logr/logr v1.4.2
 	github.com/onsi/ginkgo/v2 v2.22.1
 	github.com/onsi/gomega v1.36.2
 	github.com/prometheus/client_golang v1.22.0
@@ -28,7 +29,6 @@ require (
 	github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
 	github.com/emicklei/go-restful/v3 v3.12.2 // indirect
 	github.com/fxamacker/cbor/v2 v2.9.0 // indirect
-	github.com/go-logr/logr v1.4.2 // indirect
 	github.com/go-openapi/jsonpointer v0.21.1 // indirect
 	github.com/go-openapi/jsonreference v0.21.0 // indirect
 	github.com/go-openapi/swag v0.23.1 // indirect

test/e2e/cpu_assignment_test.go

@@ -17,8 +17,116 @@ limitations under the License.
 package e2e
 
 import (
+	"context"
+	"encoding/json"
+	"os"
+
+	"github.com/kubernetes-sigs/dra-driver-cpu/test/pkg/discovery"
+	"github.com/kubernetes-sigs/dra-driver-cpu/test/pkg/fixture"
+	"github.com/kubernetes-sigs/dra-driver-cpu/test/pkg/node"
+	e2epod "github.com/kubernetes-sigs/dra-driver-cpu/test/pkg/pod"
 	"github.com/onsi/ginkgo/v2"
+	"github.com/onsi/gomega"
+	v1 "k8s.io/api/core/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/client-go/kubernetes"
+	"k8s.io/utils/cpuset"
 )
 
-var _ = ginkgo.Describe("CPU Assignment", func() {
+var _ = ginkgo.Describe("CPU Assignment", ginkgo.Ordered, ginkgo.ContinueOnFailure, func() {
+	var rootFxt *fixture.Fixture
+	var targetNode *v1.Node
+	var targetNodeCPUInfo discovery.DRACPUInfo
+	var dracpuTesterImage string
+
+	ginkgo.BeforeAll(func(ctx context.Context) {
+		dracpuTesterImage = os.Getenv("DRACPU_TEST_IMAGE")
+		gomega.Expect(dracpuTesterImage).ToNot(gomega.BeEmpty(), "missing environment variable DRACPU_TEST_IMAGE")
+
+		var err error
+		rootFxt, err = fixture.Make("root", ctx)
+		gomega.Expect(err).ToNot(gomega.HaveOccurred(), "cannot create e2e root test fixture: %v", err)
+
+		workerNodes, err := node.FindWorkers(ctx, rootFxt.K8SClientset)
+		gomega.Expect(err).ToNot(gomega.HaveOccurred(), "cannot find worker nodes: %v", err)
+		gomega.Expect(workerNodes).ToNot(gomega.BeEmpty(), "no worker nodes detected")
+
+		targetNode = workerNodes[0] // pick random one, this is the simplest random pick
+		ginkgo.GinkgoLogr.Info("Using worker node", "nodeName", targetNode.Name)
+
+		infoPod, err := e2epod.RunToCompletion(ctx, rootFxt.K8SClientset, makeDiscoveryPod(rootFxt.Namespace.Name, dracpuTesterImage))
+		gomega.Expect(err).ToNot(gomega.HaveOccurred(), "cannot create discovery pod: %v", err)
+		data, err := e2epod.GetLogs(rootFxt.K8SClientset, ctx, infoPod.Namespace, infoPod.Name, infoPod.Spec.Containers[0].Name)
+		gomega.Expect(err).ToNot(gomega.HaveOccurred(), "cannot get logs from discovery pod: %v", err)
+		gomega.Expect(json.Unmarshal([]byte(data), &targetNodeCPUInfo)).To(gomega.Succeed())
+		ginkgo.GinkgoLogr.Info("checking worker node", "coreCount", len(targetNodeCPUInfo.CPUs))
+
+		gomega.Expect(rootFxt.Teardown(ctx)).To(gomega.Succeed())
+	})
+
+	ginkgo.When("not setting resource claims", func() {
+		ginkgo.It("should grant best-effort pods access to all system CPUs", func(ctx context.Context) {
+			fxt, err := rootFxt.MakeFrom("", ctx)
+			gomega.Expect(err).ToNot(gomega.HaveOccurred(), "cannot create test fixture: %v", err)
+			ginkgo.DeferCleanup(fxt.Teardown, context.TODO()) // TODO
+
+			pod, err := e2epod.CreateSync(ctx, fxt.K8SClientset, makeTesterPodBestEffort(rootFxt.Namespace.Name, dracpuTesterImage))
+			gomega.Expect(err).ToNot(gomega.HaveOccurred(), "cannot create tester pod: %v", err)
+
+			cpus, err := getTesterPodCPUAllocation(fxt.K8SClientset, ctx, pod)
+			gomega.Expect(err).ToNot(gomega.HaveOccurred(), "cannot get the CPUs allocated to tester pod %s/%s", pod.Namespace, pod.Name)
+			gomega.Expect(cpus.Size()).To(gomega.Equal(len(targetNodeCPUInfo.CPUs)))
+		})
+	})
 })
+
+func getTesterPodCPUAllocation(cs kubernetes.Interface, ctx context.Context, pod *v1.Pod) (cpuset.CPUSet, error) {
+	data, err := e2epod.GetLogs(cs, ctx, pod.Namespace, pod.Name, pod.Spec.Containers[0].Name)
+	if err != nil {
+		return cpuset.CPUSet{}, err
+	}
+	testerInfo := discovery.DRACPUTester{}
+	err = json.Unmarshal([]byte(data), &testerInfo)
+	if err != nil {
+		return cpuset.CPUSet{}, err
+	}
+	return cpuset.Parse(testerInfo.Allocation.CPUs)
+}
+
+func makeTesterPodBestEffort(ns, image string) *v1.Pod {
+	return &v1.Pod{
+		ObjectMeta: metav1.ObjectMeta{
+			GenerateName: "tester-pod-",
+			Namespace:    ns,
+		},
+		Spec: v1.PodSpec{
+			Containers: []v1.Container{
+				{
+					Name:    "tester-container",
+					Image:   image,
+					Command: []string{"/dracputester"},
+				},
+			},
+			RestartPolicy: v1.RestartPolicyAlways,
+		},
+	}
+}
+func makeDiscoveryPod(ns, image string) *v1.Pod {
+	return &v1.Pod{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "discovery-pod",
+			Namespace: ns,
+		},
+		Spec: v1.PodSpec{
+			Containers: []v1.Container{
+				{
+					Name:            "discovery-container",
+					Image:           image,
+					ImagePullPolicy: v1.PullIfNotPresent,
+					Command:         []string{"/dracpuinfo"},
+				},
+			},
+			RestartPolicy: v1.RestartPolicyNever,
+		},
+	}
+}

test/pkg/client/k8s.go

@@ -0,0 +1,39 @@
+/*
+Copyright 2025 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package client
+
+import (
+	"errors"
+	"fmt"
+	"os"
+
+	"k8s.io/client-go/kubernetes"
+	"k8s.io/client-go/tools/clientcmd"
+)
+
+func NewK8SClientset() (kubernetes.Interface, error) {
+	kubeconfig, ok := os.LookupEnv("KUBECONFIG")
+	if !ok {
+		return nil, errors.New("missing environment variable KUBECONFIG")
+	}
+	config, err := clientcmd.BuildConfigFromFlags("", kubeconfig)
+	if err != nil {
+		return nil, fmt.Errorf("can not create client-go configuration: %w", err)
+	}
+
+	return kubernetes.NewForConfig(config)
+}

test/pkg/fixture/fixture.go

@@ -0,0 +1,123 @@
+/*
+Copyright 2025 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package fixture
+
+import (
+	"context"
+	"fmt"
+	"time"
+
+	"github.com/go-logr/logr"
+	"github.com/kubernetes-sigs/dra-driver-cpu/test/pkg/client"
+	"github.com/onsi/ginkgo/v2"
+	v1 "k8s.io/api/core/v1"
+	apierrors "k8s.io/apimachinery/pkg/api/errors"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/util/wait"
+	"k8s.io/client-go/kubernetes"
+)
+
+type Fixture struct {
+	Prefix       string
+	K8SClientset kubernetes.Interface
+	Namespace    *v1.Namespace
+	Log          logr.Logger
+}
+
+func Make(prefix string, ctx context.Context) (*Fixture, error) {
+	cs, err := client.NewK8SClientset()
+	if err != nil {
+		return nil, err
+	}
+	return makeFixture(prefix, cs, ctx)
+}
+
+func (fxt *Fixture) MakeFrom(prefix string, ctx context.Context) (*Fixture, error) {
+	return makeFixture(prefix, fxt.K8SClientset, ctx)
+}
+
+func (fxt *Fixture) Setup(ctx context.Context) error {
+	if fxt.Namespace != nil {
+		return nil // TODO: or fail?
+	}
+	generateName := "dracpu-e2e-"
+	if fxt.Prefix != "" {
+		generateName += fxt.Prefix + "-"
+	}
+	ns := &v1.Namespace{
+		ObjectMeta: metav1.ObjectMeta{
+			GenerateName: generateName,
+		},
+	}
+	nsCreated, err := fxt.K8SClientset.CoreV1().Namespaces().Create(ctx, ns, metav1.CreateOptions{})
+	if err != nil {
+		return fmt.Errorf("failed to create namespace %s: %w", ns.Name, err)
+	}
+	fxt.Namespace = nsCreated
+	fxt.Log.Info("Fixture setup", "namespace", fxt.Namespace.Name)
+	return nil
+}
+
+func (fxt *Fixture) Teardown(ctx context.Context) error {
+	if fxt.Namespace == nil {
+		return nil // TODO: or fail?
+	}
+	err := fxt.K8SClientset.CoreV1().Namespaces().Delete(ctx, fxt.Namespace.Name, metav1.DeleteOptions{})
+	if err != nil {
+		return fmt.Errorf("failed to delete namespace %s: %w", fxt.Namespace.Name, err)
+	}
+	err = waitForNamespaceToBeDeleted(ctx, fxt.K8SClientset, fxt.Namespace.Name)
+	if err != nil {
+		return err
+	}
+	fxt.Log.Info("Fixture teardown", "namespace", fxt.Namespace.Name)
+	fxt.Namespace = nil
+	return nil
+}
+
+func makeFixture(prefix string, cs kubernetes.Interface, ctx context.Context) (*Fixture, error) {
+	fxt := &Fixture{
+		Prefix:       prefix,
+		K8SClientset: cs,
+		Log:          ginkgo.GinkgoLogr,
+	}
+	err := fxt.Setup(ctx)
+	return fxt, err
+}
+
+const (
+	nsPollInterval = time.Second * 10
+	nsPollTimeout  = time.Minute * 2
+)
+
+func waitForNamespaceToBeDeleted(ctx context.Context, cs kubernetes.Interface, nsName string) error {
+	immediate := true
+	err := wait.PollUntilContextTimeout(ctx, nsPollInterval, nsPollTimeout, immediate, func(ctx2 context.Context) (done bool, err error) {
+		_, err = cs.CoreV1().Namespaces().Get(ctx2, nsName, metav1.GetOptions{})
+		if err != nil {
+			if apierrors.IsNotFound(err) {
+				return true, nil
+			}
+			return false, err
+		}
+		return false, nil
+	})
+	if err != nil {
+		return fmt.Errorf("namespace=%s was not deleted: %w", nsName, err)
+	}
+	return nil
+}

test/pkg/node/node.go

@@ -0,0 +1,52 @@
+/*
+Copyright 2025 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package node
+
+import (
+	"context"
+
+	v1 "k8s.io/api/core/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/labels"
+	"k8s.io/client-go/kubernetes"
+)
+
+func FindWorkers(ctx context.Context, cs kubernetes.Interface) ([]*v1.Node, error) {
+	selector := labels.Set{"node-role.kubernetes.io/worker": ""}.AsSelector()
+	nodeList, err := cs.CoreV1().Nodes().List(ctx, metav1.ListOptions{LabelSelector: selector.String()})
+	if err != nil {
+		return nil, err
+	}
+
+	var workerNodes []*v1.Node
+	for _, n := range nodeList.Items {
+		if !IsReady(&n) {
+			continue
+		}
+		workerNodes = append(workerNodes, &n)
+	}
+	return workerNodes, nil
+}
+
+func IsReady(node *v1.Node) bool {
+	for _, cond := range node.Status.Conditions {
+		if cond.Type == v1.NodeReady {
+			return cond.Status == v1.ConditionTrue
+		}
+	}
+	return false
+}