Skip to content

Commit 69795ff

Browse files
committed
Changes due to package refactoring
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
1 parent 661decd commit 69795ff

4 files changed

Lines changed: 9 additions & 7 deletions

File tree

pkg/bbr/handlers/server.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import (
2828
"sigs.k8s.io/controller-runtime/pkg/log"
2929

3030
"sigs.k8s.io/gateway-api-inference-extension/pkg/bbr/framework"
31+
reqenvoy "sigs.k8s.io/gateway-api-inference-extension/pkg/common/envoy/request"
3132
logutil "sigs.k8s.io/gateway-api-inference-extension/pkg/common/observability/logging"
3233
reqcommon "sigs.k8s.io/gateway-api-inference-extension/pkg/common/request"
3334
)
@@ -83,7 +84,7 @@ func (s *Server) Process(srv extProcPb.ExternalProcessor_ProcessServer) error {
8384
// If streaming and the body is not empty, then headers are handled when processing request body.
8485
loggerVerbose.Info("Received headers, passing off header processing until body arrives...")
8586
} else {
86-
if requestId := reqcommon.ExtractHeaderValue(v, reqcommon.RequestIdHeaderKey); len(requestId) > 0 {
87+
if requestId := reqenvoy.ExtractHeaderValue(v, reqcommon.RequestIdHeaderKey); len(requestId) > 0 {
8788
logger = logger.WithValues(reqcommon.RequestIdHeaderKey, requestId)
8889
loggerVerbose = logger.V(logutil.VERBOSE)
8990
ctx = log.IntoContext(ctx, logger)

pkg/epp/handlers/request.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import (
2929
"google.golang.org/protobuf/types/known/structpb"
3030

3131
"sigs.k8s.io/gateway-api-inference-extension/pkg/common"
32-
reqcommon "sigs.k8s.io/gateway-api-inference-extension/pkg/common/request"
32+
reqenvoy "sigs.k8s.io/gateway-api-inference-extension/pkg/common/envoy/request"
3333
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/metadata"
3434
errutil "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/error"
3535
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/request"
@@ -55,7 +55,7 @@ func (s *StreamingServer) HandleRequestHeaders(ctx context.Context, reqCtx *Requ
5555
}
5656

5757
for _, header := range req.RequestHeaders.Headers.Headers {
58-
reqCtx.Request.Headers[header.Key] = reqcommon.GetHeaderValue(header)
58+
reqCtx.Request.Headers[header.Key] = reqenvoy.GetHeaderValue(header)
5959
switch header.Key {
6060
case metadata.FlowFairnessIDKey:
6161
reqCtx.FairnessID = reqCtx.Request.Headers[header.Key]

pkg/epp/handlers/response.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ import (
2626
"sigs.k8s.io/controller-runtime/pkg/log"
2727

2828
"sigs.k8s.io/gateway-api-inference-extension/pkg/common"
29+
reqenvoy "sigs.k8s.io/gateway-api-inference-extension/pkg/common/envoy/request"
2930
logutil "sigs.k8s.io/gateway-api-inference-extension/pkg/common/observability/logging"
30-
reqcommon "sigs.k8s.io/gateway-api-inference-extension/pkg/common/request"
3131
fwkrq "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/framework/interface/requestcontrol"
3232
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/metrics"
3333
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/request"
@@ -151,7 +151,7 @@ func (s *StreamingServer) HandleResponseBodyModelStreaming(ctx context.Context,
151151

152152
func (s *StreamingServer) HandleResponseHeaders(ctx context.Context, reqCtx *RequestContext, resp *extProcPb.ProcessingRequest_ResponseHeaders) (*RequestContext, error) {
153153
for _, header := range resp.ResponseHeaders.Headers.Headers {
154-
reqCtx.Response.Headers[header.Key] = reqcommon.GetHeaderValue(header)
154+
reqCtx.Response.Headers[header.Key] = reqenvoy.GetHeaderValue(header)
155155
}
156156

157157
reqCtx, err := s.director.HandleResponseReceived(ctx, reqCtx)

pkg/epp/handlers/server.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ import (
3333
"google.golang.org/protobuf/types/known/structpb"
3434
"sigs.k8s.io/controller-runtime/pkg/log"
3535

36+
reqenvoy "sigs.k8s.io/gateway-api-inference-extension/pkg/common/envoy/request"
3637
logutil "sigs.k8s.io/gateway-api-inference-extension/pkg/common/observability/logging"
3738
reqcommon "sigs.k8s.io/gateway-api-inference-extension/pkg/common/request"
3839
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/datalayer"
@@ -197,11 +198,11 @@ func (s *StreamingServer) Process(srv extProcPb.ExternalProcessor_ProcessServer)
197198
return status.Errorf(codes.Unknown, "cannot receive stream request: %v", err)
198199
}
199200

200-
reqCtx.Request.Metadata = reqcommon.ExtractMetadataValues(req)
201+
reqCtx.Request.Metadata = reqenvoy.ExtractMetadataValues(req)
201202

202203
switch v := req.Request.(type) {
203204
case *extProcPb.ProcessingRequest_RequestHeaders:
204-
requestID := reqcommon.ExtractHeaderValue(v, reqcommon.RequestIdHeaderKey)
205+
requestID := reqenvoy.ExtractHeaderValue(v, reqcommon.RequestIdHeaderKey)
205206
// request ID is a must for maintaining a state per request in plugins that hold internal state and use PluginState.
206207
// if request id was not supplied as a header, we generate it ourselves.
207208
if len(requestID) == 0 {

0 commit comments

Comments
 (0)