Skip to content

Commit a4b8a6b

Browse files
committed
Log only when the entire body is sent back to proxy
1 parent 7fce268 commit a4b8a6b

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

pkg/epp/handlers/server.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -213,9 +213,7 @@ func (s *StreamingServer) Process(srv extProcPb.ExternalProcessor_ProcessServer)
213213
reqCtx.Request.Headers[requtil.RequestIdHeaderKey] = requestID // update in headers so director can consume it
214214
}
215215
logger = logger.WithValues(requtil.RequestIdHeaderKey, requestID)
216-
217216
logger.Info("EPP received request") // Request ID will be logged too as part of logger context values.
218-
219217
loggerTrace = logger.V(logutil.TRACE)
220218
ctx = log.IntoContext(ctx, logger)
221219

@@ -277,7 +275,6 @@ func (s *StreamingServer) Process(srv extProcPb.ExternalProcessor_ProcessServer)
277275
loggerTrace.Info("model server is streaming response")
278276
}
279277
}
280-
281278
reqCtx.RequestState = ResponseReceived
282279

283280
var responseErr error
@@ -372,7 +369,6 @@ func (s *StreamingServer) Process(srv extProcPb.ExternalProcessor_ProcessServer)
372369
logger.V(logutil.DEFAULT).Error(err, "Send failed")
373370
return status.Errorf(codes.Unknown, "failed to send response back to Envoy: %v", err)
374371
}
375-
376372
return nil
377373
}
378374
loggerTrace.Info("checking", "request state", reqCtx.RequestState)
@@ -431,10 +427,10 @@ func (r *RequestContext) updateStateAndSendIfNeeded(srv extProcPb.ExternalProces
431427

432428
body := response.Response.(*extProcPb.ProcessingResponse_ResponseBody)
433429
if body.ResponseBody.Response.GetBodyMutation().GetStreamedResponse().GetEndOfStream() {
430+
logger.Info("EPP sent response body back to proxy")
434431
r.RequestState = BodyResponseResponsesComplete
435432
}
436433
}
437-
logger.Info("EPP sent response body back to proxy")
438434
// Dump the response so a new stream message can begin
439435
r.respBodyResp = nil
440436
}

0 commit comments

Comments
 (0)