🌱 infra: Remove pkg/internal/validation (#5512)

vitorfloriano · web-flow · commit 98ed8101b7eb · 2026-02-26T15:57:55.000Z
infra: remove validation package

Package validation was copied from k8s.io/apimachinery/utils/validation to avoid adding a dependency. Considering that kubebuilder already depends on apimachinery, using the original package requires less maintainance.
diff --git a/pkg/internal/validation/dns.go b/pkg/internal/validation/dns.go
diff --git a/pkg/internal/validation/dns_test.go b/pkg/internal/validation/dns_test.go
diff --git a/pkg/model/resource/gvk.go b/pkg/model/resource/gvk.go
@@ -21,7 +21,7 @@ import (
 	"fmt"
 	"strings"
 
-	"sigs.k8s.io/kubebuilder/v4/pkg/internal/validation"
+	"k8s.io/apimachinery/pkg/util/validation"
 )
 
 const (
diff --git a/pkg/model/resource/resource.go b/pkg/model/resource/resource.go
@@ -20,7 +20,7 @@ import (
 	"fmt"
 	"strings"
 
-	"sigs.k8s.io/kubebuilder/v4/pkg/internal/validation"
+	"k8s.io/apimachinery/pkg/util/validation"
 )
 
 // Resource contains the information required to scaffold files for a resource.
diff --git a/pkg/plugin/helpers.go b/pkg/plugin/helpers.go
@@ -22,8 +22,9 @@ import (
 	"slices"
 	"strings"
 
+	"k8s.io/apimachinery/pkg/util/validation"
+
 	"sigs.k8s.io/kubebuilder/v4/pkg/config"
-	"sigs.k8s.io/kubebuilder/v4/pkg/internal/validation"
 )
 
 // KeyFor returns a Plugin's unique identifying string.
diff --git a/pkg/plugins/common/kustomize/v2/init.go b/pkg/plugins/common/kustomize/v2/init.go
@@ -23,9 +23,9 @@ import (
 	"strings"
 
 	"github.com/spf13/pflag"
+	"k8s.io/apimachinery/pkg/util/validation"
 
 	"sigs.k8s.io/kubebuilder/v4/pkg/config"
-	"sigs.k8s.io/kubebuilder/v4/pkg/internal/validation"
 	"sigs.k8s.io/kubebuilder/v4/pkg/machinery"
 	"sigs.k8s.io/kubebuilder/v4/pkg/plugin"
 	"sigs.k8s.io/kubebuilder/v4/pkg/plugins/common/kustomize/v2/scaffolds"

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ import (`
`21`	`21`	`"fmt"`
`22`	`22`	`"strings"`
`23`	`23`
`24`		`- "sigs.k8s.io/kubebuilder/v4/pkg/internal/validation"`
	`24`	`+ "k8s.io/apimachinery/pkg/util/validation"`
`25`	`25`	`)`
`26`	`26`
`27`	`27`	`const (`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ import (`
`20`	`20`	`"fmt"`
`21`	`21`	`"strings"`
`22`	`22`
`23`		`- "sigs.k8s.io/kubebuilder/v4/pkg/internal/validation"`
	`23`	`+ "k8s.io/apimachinery/pkg/util/validation"`
`24`	`24`	`)`
`25`	`25`
`26`	`26`	`// Resource contains the information required to scaffold files for a resource.`
Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,9 @@ import (`
`22`	`22`	`"slices"`
`23`	`23`	`"strings"`
`24`	`24`
	`25`	`+ "k8s.io/apimachinery/pkg/util/validation"`
	`26`	`+`
`25`	`27`	`"sigs.k8s.io/kubebuilder/v4/pkg/config"`
`26`		`- "sigs.k8s.io/kubebuilder/v4/pkg/internal/validation"`
`27`	`28`	`)`
`28`	`29`
`29`	`30`	`// KeyFor returns a Plugin's unique identifying string.`