Skip to content

Commit 130e058

Browse files
Merge pull request #116743 from thockin/docs-clarify-publish-not-ready-endpoints
Clarify EPSlice docs wrt the Ready conditions Kubernetes-commit: 3cf9f66e90d560ac080687610933c712bcf37b39
2 parents bad7d34 + c5c9df1 commit 130e058

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

discovery/v1/generated.proto

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

discovery/v1/types.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,9 @@ type EndpointConditions struct {
130130
// according to whatever system is managing the endpoint. A nil value
131131
// indicates an unknown state. In most cases consumers should interpret this
132132
// unknown state as ready. For compatibility reasons, ready should never be
133-
// "true" for terminating endpoints.
133+
// "true" for terminating endpoints, except when the normal readiness
134+
// behavior is being explicitly overridden, for example when the associated
135+
// Service has set the publishNotReadyAddresses flag.
134136
// +optional
135137
Ready *bool `json:"ready,omitempty" protobuf:"bytes,1,name=ready"`
136138

discovery/v1/types_swagger_doc_generated.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ func (Endpoint) SwaggerDoc() map[string]string {
4545

4646
var map_EndpointConditions = map[string]string{
4747
"": "EndpointConditions represents the current condition of an endpoint.",
48-
"ready": "ready indicates that this endpoint is prepared to receive traffic, according to whatever system is managing the endpoint. A nil value indicates an unknown state. In most cases consumers should interpret this unknown state as ready. For compatibility reasons, ready should never be \"true\" for terminating endpoints.",
48+
"ready": "ready indicates that this endpoint is prepared to receive traffic, according to whatever system is managing the endpoint. A nil value indicates an unknown state. In most cases consumers should interpret this unknown state as ready. For compatibility reasons, ready should never be \"true\" for terminating endpoints, except when the normal readiness behavior is being explicitly overridden, for example when the associated Service has set the publishNotReadyAddresses flag.",
4949
"serving": "serving is identical to ready except that it is set regardless of the terminating state of endpoints. This condition should be set to true for a ready endpoint that is terminating. If nil, consumers should defer to the ready condition.",
5050
"terminating": "terminating indicates that this endpoint is terminating. A nil value indicates an unknown state. Consumers should interpret this unknown state to mean that the endpoint is not terminating.",
5151
}

0 commit comments

Comments
 (0)