Skip to content

Commit 4c336d2

Browse files
committed
KEP-3542 Clarify further kubelet-config options
1 parent f0d3191 commit 4c336d2

File tree

1 file changed

+11
-4
lines changed
  • keps/sig-node/3542-cri-image-pulling-with-progress-notification

1 file changed

+11
-4
lines changed

keps/sig-node/3542-cri-image-pulling-with-progress-notification/README.md

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -258,15 +258,22 @@ The granularity type and interval should be configurable through kubelet-config.
258258
Suggested new Kubelet config fields are these:
259259

260260
// ImagePullProgressType is the type of ImagePullProgressInterval.
261+
// Supported values are
262+
// - "time" for tunrime to report progress every ImagePullProgressInterval seconds
263+
// - "size" for runtime to report progress every ImagePullProgressInterval <binarySI quantity> (e.g. 1Gi)
261264
// Default: "time"
262265
// +optional
263266
ImagePullProgressType string `json:"ImagePullProgressType,omitempty"`
264-
// ImagePullProgressInterval is an interval of type ImagePullProgressType, based on which the
265-
// runtime should send back to kubelet image pulling progress reports, that will be published
266-
// as Pod events.
267+
// ImagePullProgressInterval is a quantity value of how often the runtime should send back to
268+
// kubelet image pulling progress reports, that will be published as Pod events.
269+
// This option is used together with ImagePullProgressType in ImageService to fill Interval and
270+
// GranularityType fields respectively in PullImageWithProgressRequest in CRI PullImageWithProgress.
271+
// ImagePullProgressInterval is treated as seconds if ImagePullProgressType is "time".
272+
// ImagePullProgressInterval is treated as binarySI quantity if ImagePullProgressType is "size".
273+
// call.
267274
// Default: 30
268275
// +optional
269-
ImagePullProgressInterval uint64 `json:"ImagePullProgressType,omitempty"`
276+
ImagePullProgressInterval string `json:"ImagePullProgressType,omitempty"`
270277

271278
This will be easy to use in CRI-compliant command-line-tools as well as kubelet to monitor the
272279
progress and publish events to the Pod object

0 commit comments

Comments
 (0)