Skip to content

Commit 74c393e

Browse files
committed
Add graduation criteria
1 parent 6370827 commit 74c393e

File tree

1 file changed

+19
-55
lines changed
  • keps/sig-node/2238-liveness-probe-grace-period

1 file changed

+19
-55
lines changed

keps/sig-node/2238-liveness-probe-grace-period/README.md

Lines changed: 19 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@
1414
- [Design Details](#design-details)
1515
- [Test Plan](#test-plan)
1616
- [Graduation Criteria](#graduation-criteria)
17+
- [Alpha](#alpha)
18+
- [Beta](#beta)
19+
- [Graduation](#graduation)
1720
- [Upgrade / Downgrade Strategy](#upgrade--downgrade-strategy)
1821
- [Version Skew Strategy](#version-skew-strategy)
1922
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
@@ -33,13 +36,13 @@
3336

3437
Items marked with (R) are required *prior to targeting to a milestone / release*.
3538

36-
- [ ] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
37-
- [ ] (R) KEP approvers have approved the KEP status as `implementable`
38-
- [ ] (R) Design details are appropriately documented
39-
- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
40-
- [ ] (R) Graduation criteria is in place
41-
- [ ] (R) Production readiness review completed
42-
- [ ] (R) Production readiness review approved
39+
- [X] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
40+
- [X] (R) KEP approvers have approved the KEP status as `implementable`
41+
- [X] (R) Design details are appropriately documented
42+
- [X] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
43+
- [X] (R) Graduation criteria is in place
44+
- [X] (R) Production readiness review completed
45+
- [X] (R) Production readiness review approved
4346
- [ ] "Implementation History" section is up-to-date for milestone
4447
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
4548
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
@@ -189,60 +192,21 @@ quickly.
189192

190193
### Graduation Criteria
191194

192-
<!--
193-
**Note:** *Not required until targeted at a release.*
194-
195-
Define graduation milestones.
196-
197-
These may be defined in terms of API maturity, or as something else. The KEP
198-
should keep this high-level with a focus on what signals will be looked at to
199-
determine graduation.
200-
201-
Consider the following in developing the graduation criteria for this enhancement:
202-
- [Maturity levels (`alpha`, `beta`, `stable`)][maturity-levels]
203-
- [Deprecation policy][deprecation-policy]
204-
205-
Clearly define what graduation means by either linking to the [API doc
206-
definition](https://kubernetes.io/docs/concepts/overview/kubernetes-api/#api-versioning)
207-
or by redefining what graduation means.
208-
209-
In general we try to use the same stages (alpha, beta, GA), regardless of how the
210-
functionality is accessed.
195+
#### Alpha
211196

212-
[maturity-levels]: https://git.k8s.io/community/contributors/devel/sig-architecture/api_changes.md#alpha-beta-and-stable-versions
213-
[deprecation-policy]: https://kubernetes.io/docs/reference/using-api/deprecation-policy/
197+
- New probe field, `terminationGracePeriodSeconds`, is implemented and
198+
available behind a feature flag.
199+
- Appropriate tests are written.
214200

215-
Below are some examples to consider, in addition to the aforementioned [maturity levels][maturity-levels].
201+
_Below graduation criteria are tentative._
216202

217-
#### Alpha -> Beta Graduation
203+
#### Beta
218204

219-
- Gather feedback from developers and surveys
220-
- Complete features A, B, C
221-
- Tests are in Testgrid and linked in KEP
205+
- Feature flag is defaulted on.
222206

223-
#### Beta -> GA Graduation
207+
#### Graduation
224208

225-
- N examples of real-world usage
226-
- N installs
227-
- More rigorous forms of testing—e.g., downgrade tests and scalability tests
228-
- Allowing time for feedback
229-
230-
**Note:** Generally we also wait at least two releases between beta and
231-
GA/stable, because there's no opportunity for user feedback, or even bug reports,
232-
in back-to-back releases.
233-
234-
#### Removing a Deprecated Flag
235-
236-
- Announce deprecation and support policy of the existing flag
237-
- Two versions passed since introducing the functionality that deprecates the flag (to address version skew)
238-
- Address feedback on usage/changed behavior, provided on GitHub issues
239-
- Deprecate the flag
240-
241-
**For non-optional features moving to GA, the graduation criteria must include
242-
[conformance tests].**
243-
244-
[conformance tests]: https://git.k8s.io/community/contributors/devel/sig-architecture/conformance-tests.md
245-
-->
209+
- Feature flag is removed, feature is graduated.
246210

247211
### Upgrade / Downgrade Strategy
248212

0 commit comments

Comments
 (0)