Skip to content

Commit 76d5028

Browse files
committed
Remove feature flag, add prod-readiness, set to implementable
1 parent 4b1a17d commit 76d5028

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
kep-number: 2885
2+
alpha:
3+
approver: "@smarterclayton"

keps/sig-api-machinery/2885-server-side-unknown-field-validation/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -631,11 +631,11 @@ This section must be completed when targeting alpha to a release.
631631

632632
<!--
633633
Pick one of these and delete the rest.
634-
-->
635634
636635
- [x] Feature gate (also fill in values in `kep.yaml`)
637636
- Feature gate name: UnknownFieldValidation
638637
- Components depending on the feature gate: kube-apiserver
638+
-->
639639
- [x] Other
640640
- Describe the mechanism: query parameter
641641
- Will enabling / disabling the feature require downtime of the control
@@ -649,8 +649,8 @@ No, strict validation is false by default.
649649

650650
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?
651651

652-
Yes, disabling the feature flag will cause us to ignore the validation query
653-
param, effectively rolling back this feature.
652+
Yes, not setting the query param will ensure we are not doing strict validation
653+
(i.e. disable the feature)
654654

655655
###### What happens if we reenable the feature if it was previously rolled back?
656656

keps/sig-api-machinery/2885-server-side-unknown-field-validation/kep.yaml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ authors:
44
- "@kevindelgado"
55
owning-sig: sig-api-machinery
66
participating-sigs:
7-
status: provisional
7+
status: implementable
88
creation-date: 2021-08-20
99
reviewers:
1010
- "@apelisse"
1111
- "@jpbetz"
1212
approvers:
13-
- "@lavalamp"
13+
- "@smarterclayton"
1414

1515
##### WARNING !!! ######
1616
# prr-approvers has been moved to its own location
@@ -38,10 +38,6 @@ milestone:
3838

3939
# The following PRR answers are required at alpha release
4040
# List the feature gate name and the components for which it must be enabled
41-
feature-gates:
42-
- name: UnknownFieldValidation
43-
components:
44-
- kube-apiserver
4541
disable-supported: true
4642

4743
# The following PRR answers are required at beta release

0 commit comments

Comments
 (0)