Skip to content

Commit 7c0665e

Browse files
committed
Add test plans
Signed-off-by: kerthcet <[email protected]>
1 parent 4fbd37c commit 7c0665e

File tree

2 files changed

+82
-2
lines changed

2 files changed

+82
-2
lines changed

keps/sig-scheduling/785-scheduler-component-config-api/README.md

Lines changed: 81 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
- [x] (R) Production readiness review completed
3636
- [x] Production readiness review approved
3737
- [x] "Implementation History" section is up-to-date for milestone
38-
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
38+
- [x] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
3939
- [ ] Supporting documentation e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
4040

4141
[kubernetes.io]: https://kubernetes.io/
@@ -133,13 +133,93 @@ This will be documented in https://kubernetes.io/docs/reference/scheduling/profi
133133

134134
### Test Plan
135135

136+
<!--
137+
**Note:** *Not required until targeted at a release.*
138+
The goal is to ensure that we don't accept enhancements with inadequate testing.
139+
140+
All code is expected to have adequate tests (eventually with coverage
141+
expectations). Please adhere to the [Kubernetes testing guidelines][testing-guidelines]
142+
when drafting this test plan.
143+
144+
[testing-guidelines]: https://git.k8s.io/community/contributors/devel/sig-testing/testing.md
145+
-->
146+
136147
- [x] Compatibility tests for defaults and overrides of `.bindTimeoutSeconds`
137148
in `VolumeBindingArgs` type.
138149
- [x] Tests for `RequestedToCapacityRatioArgs` that: (1) fail to pass with
139150
bad casing and (2) get encoded with lower case.
140151
- [x] Tests for parsing, conversion, defaulting and validation.
141152
- [] Tests which assert predictability of node assignment with increased weights.
142153

154+
[x] I/we understand the owners of the involved components may require updates to
155+
existing tests to make this code solid enough prior to committing the changes necessary
156+
to implement this enhancement.
157+
158+
##### Prerequisite testing updates
159+
160+
<!--
161+
Based on reviewers feedback describe what additional tests need to be added prior
162+
implementing this enhancement to ensure the enhancements have also solid foundations.
163+
-->
164+
None
165+
166+
##### Unit tests
167+
168+
<!--
169+
In principle every added code should have complete unit test coverage, so providing
170+
the exact set of tests will not bring additional value.
171+
However, if complete unit test coverage is not possible, explain the reason of it
172+
together with explanation why this is acceptable.
173+
-->
174+
175+
<!--
176+
Additionally, for Alpha try to enumerate the core package you will be touching
177+
to implement this enhancement and provide the current unit coverage for those
178+
in the form of:
179+
- <package>: <date> - <current test coverage>
180+
The data can be easily read from:
181+
https://testgrid.k8s.io/sig-testing-canaries#ci-kubernetes-coverage-unit
182+
183+
This can inform certain test coverage improvements that we want to do before
184+
extending the production code to implement this enhancement.
185+
-->
186+
187+
- `cmd/kube-scheduler/app`: `2022-06-13` - `32.2%`
188+
- `cmd/kube-scheduler/app/options`: `2022-06-13` - `42.2%`
189+
- `pkg/scheduler/apis/config/scheme`: `2022-06-13` - `100%`
190+
- `pkg/scheduler/apis/config/v1`: `2022-06-13` - `0%`
191+
- `pkg/scheduler/apis/config/validation`: `2022-06-13` - `93.9%`
192+
193+
194+
##### Integration tests
195+
196+
<!--
197+
This question should be filled when targeting a release.
198+
For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
199+
200+
For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
201+
https://storage.googleapis.com/k8s-triage/index.html
202+
-->
203+
We have no special integration tests to cover the graduation of Component Config. But we do
204+
cover the latest Component Config in scheduling by using the latest version. See
205+
- [Configuring plugins with the latest Component Config](https://github.com/kubernetes/kubernetes/blob/master/test/integration/scheduler/plugins/plugins_test.go)
206+
- [Preemption](https://github.com/kubernetes/kubernetes/blob/master/test/integration/scheduler/preemption/preemption_test.go)
207+
- [Queueing](https://github.com/kubernetes/kubernetes/blob/master/test/integration/scheduler/queue_test.go)
208+
- [Scheduling in score](https://github.com/kubernetes/kubernetes/blob/master/test/integration/scheduler/scoring/priorities_test.go)
209+
210+
##### e2e tests
211+
212+
<!--
213+
This question should be filled when targeting a release.
214+
For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
215+
216+
For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
217+
https://storage.googleapis.com/k8s-triage/index.html
218+
219+
We expect no non-infra related flakes in the last month as a GA graduation criteria.
220+
-->
221+
None.
222+
143223
### Graduation Criteria
144224

145225
#### Alpha -> Beta Graduation

keps/sig-scheduling/785-scheduler-component-config-api/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ authors:
55
owning-sig: sig-scheduling
66
participating-sigs:
77
- sig-architecture
8-
status: implemented
8+
status: implementable
99
creation-date: 2020-05-08
1010
reviewers:
1111
- "@Huang-Wei"

0 commit comments

Comments
 (0)